Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 12, 2025

Link issues

fixes #6213

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove outdated dynamic bootstrap loading instructions from the installation documentation and simplify the script addition step, updating locale files accordingly.

Bug Fixes:

Enhancements:

  • Simplify the heading for adding scripts in Install_WebApp.razor by removing the 9.7.1 version note.

Documentation:

  • Remove dynamic load bootstrap documentation from Install_WebApp.razor.
  • Update en-US.json and zh-CN.json locales to reflect removed documentation content.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jun 12, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 12, 2025

Reviewer's Guide

This PR streamlines the Bootstrap setup documentation by removing the dynamic load/version-specific script note and cleaning up related locale entries.

File-Level Changes

Change Details Files
Simplify Install_WebApp.razor script inclusion step
  • Removed the version-conditional note “(9.7.1 版本后可跳过此步骤)” from the step heading
  • Updated the
    heading to always prompt adding the BootstrapBlazor script
src/BootstrapBlazor.Server/Components/Pages/Install_WebApp.razor
Remove obsolete locale entries for dynamic load instructions
  • Deleted corresponding translation key/value pairs in en-US.json
  • Deleted corresponding translation key/value pairs in zh-CN.json
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json

Assessment against linked issues

Issue Objective Addressed Explanation
#6213 Remove dynamic load bootstrap doc.
#6213 Add sample code for {Component}. The PR removes documentation related to dynamic loading of Bootstrap but does not add sample code for any specific component as requested in the issue body.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 12, 2025
@ArgoZhang ArgoZhang merged commit f120ef6 into main Jun 12, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the doc-bs branch June 12, 2025 00:18
@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4203dd) to head (ac96090).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          704       704           
  Lines        31093     31093           
  Branches      4395      4395           
=========================================
  Hits         31093     31093           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Bootstrap): remove dynamic load bootstrap doc

2 participants