Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 12, 2025

Link issues

fixes #6206

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Use ordinal ignore-case comparison for query string detection in route URLs and remove legacy .NET5-specific RouteTableFactory implementation.

Bug Fixes:

  • Make URL query string detection case-insensitive by using StringComparison.OrdinalIgnoreCase in RouteTableFactory.

Enhancements:

  • Remove obsolete NET5_0 preprocessor conditional and unify RouteTableFactory logic for supported frameworks.

@bb-auto bb-auto bot added the bug Something isn't working label Jun 12, 2025
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 12, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 12, 2025

Reviewer's Guide

This PR removes the legacy NET5_0 preprocessor branch in RouteTableFactory and improves URL query‐string trimming by using a case‐insensitive IndexOf overload.

Updated Class Diagram for RouteTableFactory

classDiagram
    class RouteTableFactory {
        <<static>>
        - Routes: Microsoft.AspNetCore.Components.Routing.IRouteTable
        - _routeTable: Microsoft.AspNetCore.Components.Routing.IRouteTable
        - _assemblies: HashSet~System.Reflection.Assembly~
        + Create(assemblies: IEnumerable~System.Reflection.Assembly~, url: string): BootstrapBlazor.Components.RouteContext
        - RefreshRouteTable(assemblies: IEnumerable~System.Reflection.Assembly~): void
    }
Loading

File-Level Changes

Change Details Files
Unify RouteTableFactory implementation by removing legacy NET5_0 branch
  • Deleted the entire #if NET5_0 ... #else block
  • Removed old Create and RefreshRouteTable methods under NET5_0
  • Eliminated the unnecessary #endif
src/BootstrapBlazor/Router/RouteTableFactory.cs
Use case‐insensitive comparison when trimming the query string
  • Replaced url.IndexOf("?") with url.IndexOf("?", StringComparison.OrdinalIgnoreCase)
  • Stored the result in a local 'len' variable and sliced url accordingly
src/BootstrapBlazor/Router/RouteTableFactory.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6206 Fix the bug where navigating to a URL with a querystring parameter in the Thai language environment causes an error.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit c0e8878 into main Jun 12, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the fix-router branch June 12, 2025 00:47
@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f120ef6) to head (544086e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          704       704           
  Lines        31093     31093           
  Branches      4395      4395           
=========================================
  Hits         31093     31093           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Tab): 本地化语言功能,泰语情况下 ,导航到带有Querystring 参数的URL时出错

2 participants