-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(Tab): add OrdinalIgnoreCase parameter compatible locales #6215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR removes the legacy NET5_0 preprocessor branch in RouteTableFactory and improves URL query‐string trimming by using a case‐insensitive IndexOf overload. Updated Class Diagram for RouteTableFactoryclassDiagram
class RouteTableFactory {
<<static>>
- Routes: Microsoft.AspNetCore.Components.Routing.IRouteTable
- _routeTable: Microsoft.AspNetCore.Components.Routing.IRouteTable
- _assemblies: HashSet~System.Reflection.Assembly~
+ Create(assemblies: IEnumerable~System.Reflection.Assembly~, url: string): BootstrapBlazor.Components.RouteContext
- RefreshRouteTable(assemblies: IEnumerable~System.Reflection.Assembly~): void
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6215 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31093 31093
Branches 4395 4395
=========================================
Hits 31093 31093
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Link issues
fixes #6206
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Use ordinal ignore-case comparison for query string detection in route URLs and remove legacy .NET5-specific RouteTableFactory implementation.
Bug Fixes:
Enhancements: