Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 14, 2025

Link issues

fixes #6229

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Move global pre styling (color, margin, max-height) from BaseLayout CSS to the Pre component CSS under a .pre-code > pre selector

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jun 14, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 14, 2025

Reviewer's Guide

This PR refactors code block styling by removing the global ::deep pre rules from the layout stylesheet and introducing a scoped .pre-code > pre selector in the Pre component’s styles, ensuring that Pre styles no longer leak into the global layout.

Class Diagram for CSS Rule Modifications

classDiagram
    class BaseLayout_razor_css {
        <<Stylesheet>>
        -String removed_rule_selector: "::deep pre"
        -String removed_color: "#e83e8c"
        -String removed_margin_bottom: "0"
        -String removed_max_height: "260px"
    }
    class Pre_razor_css {
        <<Stylesheet>>
        +String added_rule_selector: ".pre-code > pre"
        +String added_color: "#e83e8c"
        +String added_margin_bottom: "0"
        +String added_max_height: "260px"
    }
Loading

File-Level Changes

Change Details Files
Relocate code block styling from global layout to component-specific stylesheet
  • Removed global ::deep pre style block from BaseLayout.razor.css
  • Added scoped .pre-code > pre style block in Pre.razor.css with color, margin-bottom, and max-height properties
src/BootstrapBlazor.Server/Components/Layout/BaseLayout.razor.css
src/BootstrapBlazor.Server/Components/Components/Pre.razor.css
Clean up BaseLayout CSS structure
  • Adjusted indentation of the main selector after removing the pre block
src/BootstrapBlazor.Server/Components/Layout/BaseLayout.razor.css

Assessment against linked issues

Issue Objective Addressed Explanation
#6229 Update the style of the Pre component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 14, 2025
@ArgoZhang ArgoZhang merged commit a3f4227 into main Jun 14, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the feat-pre branch June 14, 2025 09:25
@codecov
Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (98384ca) to head (3b80139).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          704       704           
  Lines        31113     31113           
  Branches      4398      4398           
=========================================
  Hits         31113     31113           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Pre): update Pre style

2 participants