-
-
Notifications
You must be signed in to change notification settings - Fork 363
doc(Pre): update Pre style #6230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR refactors code block styling by removing the global ::deep pre rules from the layout stylesheet and introducing a scoped .pre-code > pre selector in the Pre component’s styles, ensuring that Pre styles no longer leak into the global layout. Class Diagram for CSS Rule ModificationsclassDiagram
class BaseLayout_razor_css {
<<Stylesheet>>
-String removed_rule_selector: "::deep pre"
-String removed_color: "#e83e8c"
-String removed_margin_bottom: "0"
-String removed_max_height: "260px"
}
class Pre_razor_css {
<<Stylesheet>>
+String added_rule_selector: ".pre-code > pre"
+String added_color: "#e83e8c"
+String added_margin_bottom: "0"
+String added_max_height: "260px"
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6230 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31113 31113
Branches 4398 4398
=========================================
Hits 31113 31113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Link issues
fixes #6229
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: