fix(Select): trigger OnSelectedItemsChanged after clear #6234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR ensures that clearing selections in single and multi-select components correctly triggers their respective change callbacks and adds tests to verify the behavior. Sequence Diagram for Clearing Single Select ComponentsequenceDiagram
actor User
participant Component as Select/SelectGeneric
participant AppLogic as Application Logic
User->>Component: Clicks 'Clear'
activate Component
Component->>Component: OnClearValue() calls base.OnClearValue(), sets SelectedItem to null/default
Component->>AppLogic: OnSelectedItemChanged(emptyItem)
activate AppLogic
AppLogic-->>Component:
deactivate AppLogic
deactivate Component
Sequence Diagram for Clearing Multi-Select ComponentsequenceDiagram
actor User
participant Component as MultiSelect/MultiSelectGeneric
participant AppLogic as Application Logic
User->>Component: Clicks 'Clear'
activate Component
Component->>Component: OnClearValue() calls base.OnClearValue(), SelectedItems.Clear()
Component->>Component: OnClearValue() calls SetValue()
activate Component
Component->>AppLogic: SetValue() calls OnSelectedItemsChanged(emptyList)
activate AppLogic
AppLogic-->>Component:
deactivate AppLogic
deactivate Component
deactivate Component
Class Diagram for Modified Select ComponentclassDiagram
class Select {
+OnSelectedItemChanged: EventCallback<SelectedItem>
#OnClearValue(): Task // Modified to call OnSelectedItemChanged
}
Class Diagram for Modified SelectGeneric ComponentclassDiagram
class SelectGeneric~TValue~ {
+OnSelectedItemChanged: EventCallback<SelectedItem~TValue~>
#OnClearValue(): Task // Modified to call OnSelectedItemChanged
}
Class Diagram for Modified MultiSelect ComponentclassDiagram
class MultiSelect {
+OnSelectedItemsChanged: EventCallback<List~SelectedItem~>
#OnClearValue(): Task // Modified to call SetValue()
-SetValue(): Task // Logic ensures OnSelectedItemsChanged is invoked
}
Class Diagram for Modified MultiSelectGeneric ComponentclassDiagram
class MultiSelectGeneric~TValue~ {
+OnSelectedItemsChanged: EventCallback<List<SelectedItem<TValue>>>
#OnClearValue(): Task // Modified to call SetValue()
-SetValue(): Task // Logic ensures OnSelectedItemsChanged is invoked
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6234 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31113 31121 +8
Branches 4398 4400 +2
=========================================
+ Hits 31113 31121 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6233
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fire selected-item change callbacks on clearing selections in Select, SelectGeneric, MultiSelect, and MultiSelectGeneric components and extend tests to verify this behavior.
Bug Fixes:
Tests: