-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(cherry-markdown): add IsSupportMath parameter #6237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: j4587698 <[email protected]>
Reviewer's GuideThis PR introduces a new IsSupportMath boolean parameter in the CherryMarkdown component to toggle math rendering support and updates the sample page to demonstrate enabling it. Class Diagram for CherryMarkdown Component UpdateclassDiagram
class CherryMarkdown {
+string Value
+string Html
+bool IsSupportMath
+string style
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6237 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31121 31121
Branches 4400 4400
=========================================
Hits 31121 31121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- I don’t see any changes in the CherryMarkdown component itself to declare and use the new IsSupportMath parameter – be sure to add
[Parameter] public bool IsSupportMath { get; set; }and integrate it into the rendering logic. - Consider lazily loading the math renderer (e.g. MathJax or KaTeX) only when IsSupportMath is true to avoid adding extra overhead for standard markdown rendering.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- I don’t see any changes in the CherryMarkdown component itself to declare and use the new IsSupportMath parameter – be sure to add `[Parameter] public bool IsSupportMath { get; set; }` and integrate it into the rendering logic.
- Consider lazily loading the math renderer (e.g. MathJax or KaTeX) only when IsSupportMath is true to avoid adding extra overhead for standard markdown rendering.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Link issues
fixes #6236
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new IsSupportMath flag to the CherryMarkdown component for optional math support and reflect this change in the demo sample.
New Features:
Documentation: