fix(Table): update table column order in OnColumnCreating not work #6242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR fixes the table component’s column reordering and width/visibility persistence by threading the updated column list through various lifecycle methods, refactors several reset/reload methods to accept explicit column collections, and converts the ColumnWidth helper from a class to a struct for value semantics. Class diagram for refactored Table column managementclassDiagram
class Table {
+List<ITableColumn> Columns
+void ResetColumnWidth(List<ITableColumn> columns)
+Task ReloadColumnWidthFromBrowserAsync(List<ITableColumn> columns)
+Task ReloadColumnOrdersFromBrowserAsync(List<ITableColumn> columns)
+void InternalResetVisibleColumns(List<ITableColumn> columns, IEnumerable<ColumnVisibleItem>? items = null)
+void ResetVisibleColumns(IEnumerable<ColumnVisibleItem> columns)
}
class ColumnWidth {
+string Name
+int Width
}
Table o-- "*" ITableColumn
Table o-- "*" ColumnVisibleItem
Table o-- "*" ColumnWidth
note for Table "Methods now accept explicit column lists for correct ordering and persistence."
note for ColumnWidth "Now a struct instead of a class."
Class diagram for ColumnWidth struct changeclassDiagram
class ColumnWidth {
+string Name
+int Width
}
note for ColumnWidth "ColumnWidth is now a struct (was a class) for value semantics."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @yacper. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the Table control where changes to a Column’s Order property in the OnColumnCreating callback were not applied. The changes include creating a copy of each column’s initial Order, comparing after the callback, and reordering the Columns collection if any changes are detected.
Member
|
@yacper 感谢提交 PR 看一下 https://www.bilibili.com/video/BV1wBM4zDEnn/?spm_id_from=333.999.0.0 把 CLA 签署一下 |
Contributor
Author
|
@microsoft-github-policy-service agree |
ArgoZhang
changed the title
ArgoZhang
approved these changes
Jun 18, 2025
ArgoZhang
approved these changes
Jun 18, 2025
Member
|
@sourcery-ai review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6242 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31130 31130
Branches 4402 4402
=========================================
Hits 31130 31130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @yacper - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Table/Table.razor.cs:1177` </location>
<code_context>
}
await ReloadColumnOrdersFromBrowserAsync(cols);
- Columns.Clear();
- Columns.AddRange(cols.OrderFunc());
// 查看是否开启列宽序列化
</code_context>
<issue_to_address>
Columns is cleared and repopulated after InternalResetVisibleColumns, which now takes cols instead of Columns.
If InternalResetVisibleColumns should use the updated columns, move Columns.Clear/AddRange before calling it.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
1177
to
1178
|
|
||
| await ReloadColumnOrdersFromBrowserAsync(cols); |
Contributor
There was a problem hiding this comment.
suggestion: Columns is cleared and repopulated after InternalResetVisibleColumns, which now takes cols instead of Columns.
If InternalResetVisibleColumns should use the updated columns, move Columns.Clear/AddRange before calling it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
close #6249
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Fix table column ordering in the OnColumnCreating callback by deferring the column list update until after ordering is applied, and ensure column widths and visibility resets operate on the updated columns collection.
Bug Fixes:
Enhancements: