Skip to content

Conversation

@momijijin
Copy link
Collaborator

@momijijin momijijin commented Jun 18, 2025

…'table' component, add some css style

Link issues

fixes #6250

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add a new ShowColorWhenToolbarButtonsCollapsed parameter to Table and TableToolbar to preserve toolbar button colors when they collapse, and include matching CSS rules for colored dropdown items.

New Features:

  • Introduce ShowColorWhenToolbarButtonsCollapsed boolean parameter on Table and TableToolbar components to toggle color inheritance for collapsed toolbar buttons.

Enhancements:

  • Add CSS rules for dropdown-menu items to apply Bootstrap color classes when toolbar buttons are collapsed.

@momijijin momijijin linked an issue Jun 18, 2025 that may be closed by this pull request
1 task
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 18, 2025

Reviewer's Guide

This PR adds a ShowColorWhenToolbarButtonsCollapsed parameter to Table and TableToolbar components to preserve original toolbar button colors when auto-collapsed, and includes accompanying CSS rules for each color variant.

File-Level Changes

Change Details Files
Introduce ShowColorWhenToolbarButtonsCollapsed parameter
  • Declare ShowColorWhenToolbarButtonsCollapsed in TableToolbar
  • Declare ShowColorWhenToolbarButtonsCollapsed in Table
  • Forward attribute in Table markup
src/BootstrapBlazor/Components/Table/TableToolbar.razor.cs
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs
src/BootstrapBlazor/Components/Table/Table.razor
Apply color classes for collapsed toolbar buttons
  • Enhance GetItemClass to add dropdown-item-btn-{color} when collapsed and enabled
src/BootstrapBlazor/Components/Table/TableToolbar.razor.cs
Define CSS rules for collapsed button color variants
  • Add background and text colors for all dropdown-item-btn-{color} classes
src/BootstrapBlazor/Components/Table/Table.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#6250 Add a boolean attribute to the 'table' component to control whether the icon button after the toolbar button is collapsed inherits the color of the original button.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto
Copy link

bb-auto bot commented Jun 18, 2025

Thanks for your PR, @momijijin. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 18, 2025
@bb-auto bb-auto bot requested a review from ArgoZhang June 18, 2025 06:48
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 18, 2025
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1469626) to head (ffb4a08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          704       704           
  Lines        31130     31137    +7     
  Branches      4402      4403    +1     
=========================================
+ Hits         31130     31137    +7     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jun 18, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @momijijin - I've reviewed your changes - here's some feedback:

  • Consider refactoring the repeated SCSS rules for each color into a Sass loop or mixin to reduce duplication.
  • The new ShowColorWhenToolbarButtonsCollapsed parameter is duplicated in both Table and TableToolbar—consider centralizing it to avoid code repetition.
  • The parameter name ShowColorWhenToolbarButtonsCollapsed is quite long; consider using a shorter, more descriptive name for improved readability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the repeated SCSS rules for each color into a Sass loop or mixin to reduce duplication.
- The new ShowColorWhenToolbarButtonsCollapsed parameter is duplicated in both Table and TableToolbar—consider centralizing it to avoid code repetition.
- The parameter name ShowColorWhenToolbarButtonsCollapsed is quite long; consider using a shorter, more descriptive name for improved readability.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

ArgoZhang
ArgoZhang previously approved these changes Jun 18, 2025
@ArgoZhang ArgoZhang changed the title feat(Table): add 'ShowColorWhenToolbarButtonsCollapsed' attribute in … feat(Table): add ShowColorWhenToolbarButtonsCollapsed parameter Jun 18, 2025
@ArgoZhang ArgoZhang merged commit 48a7777 into main Jun 18, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the 6250-feattable-add-a-boolean-attribute-to-control-whether-the-icon-button-after-the-toolbar-button-is-collapsed-inherits-the-color-of-the-original-button branch June 18, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): add ShowColorWhenToolbarButtonsCollapsed parameter

3 participants