-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Table): add ShowColorWhenToolbarButtonsCollapsed parameter #6251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…'table' component, add some css style
Reviewer's GuideThis PR adds a ShowColorWhenToolbarButtonsCollapsed parameter to Table and TableToolbar components to preserve original toolbar button colors when auto-collapsed, and includes accompanying CSS rules for each color variant. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @momijijin. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6251 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31130 31137 +7
Branches 4402 4403 +1
=========================================
+ Hits 31130 31137 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @momijijin - I've reviewed your changes - here's some feedback:
- Consider refactoring the repeated SCSS rules for each color into a Sass loop or mixin to reduce duplication.
- The new ShowColorWhenToolbarButtonsCollapsed parameter is duplicated in both Table and TableToolbar—consider centralizing it to avoid code repetition.
- The parameter name ShowColorWhenToolbarButtonsCollapsed is quite long; consider using a shorter, more descriptive name for improved readability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the repeated SCSS rules for each color into a Sass loop or mixin to reduce duplication.
- The new ShowColorWhenToolbarButtonsCollapsed parameter is duplicated in both Table and TableToolbar—consider centralizing it to avoid code repetition.
- The parameter name ShowColorWhenToolbarButtonsCollapsed is quite long; consider using a shorter, more descriptive name for improved readability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-Authored-By: jin momiji <[email protected]>
…'table' component, add some css style
Link issues
fixes #6250
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new ShowColorWhenToolbarButtonsCollapsed parameter to Table and TableToolbar to preserve toolbar button colors when they collapse, and include matching CSS rules for colored dropdown items.
New Features:
Enhancements: