-
-
Notifications
You must be signed in to change notification settings - Fork 363
perf(TreeView): use Remove method improve performance #6258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Diego2098 <[email protected]>
Reviewer's GuideThis PR refactors the ExpandableNodeCache to improve performance by replacing bulk removal filters with direct removal calls and simplifying membership checks. Class diagram for updated ExpandableNodeCache methodsclassDiagram
class ExpandableNodeCache {
+Task ToggleNodeAsync(TNode node, Func<TNode, Task<IEnumerable<IExpandableNode<TNode>>>> loadChildren)
+Task CheckExpandAsync(TNode node, Func<TNode, Task<IEnumerable<IExpandableNode<TNode>>>> loadChildren)
-HashSet<TNode> ExpandedNodeCache
-HashSet<TNode> CollapsedNodeCache
-IEqualityComparer<TNode> EqualityComparer
}
ExpandableNodeCache : uses ExpandedNodeCache
ExpandableNodeCache : uses CollapsedNodeCache
class HashSet~T~ {
+Add(T item)
+Remove(T item)
+Contains(T item)
}
ExpandableNodeCache --> HashSet~TNode~ : uses
ExpandableNodeCache --> IEqualityComparer~TNode~ : uses
class IExpandableNode~T~ {
+T Value
+bool HasChildren
+bool IsExpand
+IEnumerable<IExpandableNode<T>> Items
}
ToggleNodeAsync : modifies ExpandedNodeCache, CollapsedNodeCache
CheckExpandAsync : checks and modifies ExpandedNodeCache, CollapsedNodeCache
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6258 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 710 710
Lines 31339 31339
Branches 4424 4424
=========================================
Hits 31339 31339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6257
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Optimize TreeView node caching by replacing predicate-based removals with direct Remove calls and streamlining Contains usage
Bug Fixes:
Enhancements: