-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(OtpInput ): support responsive layout #6284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR refactors the OtpInput component to use a consistent “bb-otp-” prefix, introduces CSS custom properties (and a responsive media query) for layout control, and updates associated JavaScript handlers, C# class builders, unit tests, and sample usage accordingly. Class diagram for updated OtpInput component structureclassDiagram
class OtpInput {
+string? PlaceHolder
-string? ClassString
-string? InputClassString
}
%% Note: ClassString and InputClassString now use 'bb-otp-input' and 'bb-otp-item' respectively
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Input/OtpInput.razor.scss:37` </location>
<code_context>
--bs-border-color: var(--bs-danger);
}
+
+ &span {
+ color: var(--bb-otp-item-disabled-color);
+ }
</code_context>
<issue_to_address>
The selector '&span' is likely incorrect and may not target the intended elements.
'&span' compiles to '.bb-otp-itemspan'. Use '& span' to target a <span> inside '.bb-otp-item'.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| --bs-border-color: var(--bs-danger); | ||
| } | ||
|
|
||
| &span { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The selector '&span' is likely incorrect and may not target the intended elements.
'&span' compiles to '.bb-otp-itemspan'. Use '& span' to target a inside '.bb-otp-item'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6284 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 712 712
Lines 31397 31397
Branches 4437 4437
=========================================
Hits 31397 31397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6278
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Implement responsive styling for the OTP input component by renaming its classes to
bb-otp-*, consolidating its styling into CSS custom properties, adding a media query for larger screens, and updating the related scss, JavaScript, C# logic, and tests accordingly.New Features:
Enhancements:
bb-opt-*tobb-otp-*across styles, JavaScript, and C# codeTests: