Skip to content

Conversation

@Mydashixiong
Copy link
Collaborator

@Mydashixiong Mydashixiong commented Jun 24, 2025

Link issues

fixes #6288

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Add missing self-closing slash to img tag in ImagePreviewer.razor to correct HTML markup.

修复img没有结束符
@bb-auto
Copy link

bb-auto bot commented Jun 24, 2025

Thanks for your PR, @Mydashixiong. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 24, 2025

Reviewer's Guide

This PR corrects the HTML markup in the ImagePreviewer component by making the tag self-closing to ensure valid HTML.

File-Level Changes

Change Details Files
Make the img element a self-closing tag to fix missing end delimiter
  • Updated the tag in the viewer canvas to include a closing slash
src/BootstrapBlazor/Components/ImagePreviewer/ImagePreviewer.razor

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang June 24, 2025 01:13
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jun 24, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mydashixiong - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ed4a2a4) to head (5f3ee07).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6285   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          712       712           
  Lines        31397     31397           
  Branches      4437      4437           
=========================================
  Hits         31397     31397           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mydashixiong
Copy link
Collaborator Author

@microsoft-github-policy-service agree

@ArgoZhang ArgoZhang changed the title ImagePreviewer 修复html标签 img refactor(ImageViewer): image element is not closed Jun 24, 2025
@bb-auto bb-auto bot added the enhancement New feature or request label Jun 24, 2025
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 24, 2025
Co-Authored-By: Mydashixiong <[email protected]>
@ArgoZhang ArgoZhang merged commit 547980d into main Jun 24, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the ImagePreviewer_fit branch June 24, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(ImageViewer): image element is not closed

3 participants