-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(OfficeViewer): add OfficeViewer component #6287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR adds a new OfficeViewer component with its sample page, integrates it into the application menu and localization resources, updates project configurations, and refines existing file viewer samples. Class diagram for the new OfficeViewers componentclassDiagram
class OfficeViewers {
- List<SelectedItem> _docs
- string _doc
+ Task OnLoaded()
}
class ToastService
OfficeViewers --> ToastService : uses
class SelectedItem
OfficeViewers --> SelectedItem : contains list of
Class diagram for integration of OfficeDocumentViewer in sample pageclassDiagram
class OfficeDocumentViewer {
+string Url
+string Height
+EventCallback OnLoaded
}
class OfficeViewers {
- string _doc
+ Task OnLoaded()
}
OfficeViewers --> OfficeDocumentViewer : uses
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6287 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 712 712
Lines 31397 31397
Branches 4437 4437
=========================================
Hits 31397 31397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6286
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new OfficeViewer sample page to showcase the OfficeDocumentViewer component, integrate it into the demo navigation, and update related samples and localization.
New Features:
Enhancements:
Documentation: