Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 24, 2025

Link issues

fixes #6289

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enable drag-and-drop support across all Upload components by adding drop-zone classes, updating JavaScript event handling, and adjusting component markups and styles.

New Features:

  • Add drag-and-drop functionality to AvatarUpload, CardUpload, ButtonUpload, and InputUpload components.

Enhancements:

  • Simplify RenderAdd fragments in upload components by removing nested wrappers and consolidating CSS classes.
  • Update CSS to position upload items for drag-drop zones and apply consistent styling via an upload-drop-body class.
  • Refactor Upload JS module to improve drag/drop event handling and wrap error catch block with braces.

Tests:

  • Update unit tests to reflect new CSS class names for upload items.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 24, 2025

Reviewer's Guide

Adds drag-and-drop support across all upload components by marking drop zones in the markup and CSS, updating SCSS for overlay positioning, refining JavaScript event handling and disposal, and adjusting component class builders and tests to incorporate the new behavior.

Class diagram for updated upload components with drag-and-drop support

classDiagram
    class CardUpload {
        +string? CardItemClass
        +RenderFragment RenderAdd
    }
    class AvatarUpload {
        +string? GetItemClassString(string? classString = null)
        +RenderFragment RenderAdd
    }
    class ButtonUpload {
        +string? BrowserButtonClassString
    }
    CardUpload --|> UploadBase
    AvatarUpload --|> UploadBase
    ButtonUpload --|> UploadBase
    class UploadBase {
        <<abstract>>
    }
Loading

Flow diagram for drag-and-drop event handling in upload.js

flowchart TD
    A[User drags file over drop zone] --> B[Drop zone highlights]
    B --> C[User drops file]
    C --> D[JavaScript handles drop event]
    D --> E[InputFile receives files]
    E --> F[Change event triggered]
    F --> G[File upload process starts]
Loading

File-Level Changes

Change Details Files
Designate drop zones via CSS class and simplify upload markup
  • Add upload-drop-body to upload triggers and wrappers
  • Remove nested action containers and inline the add-icon
  • Apply btn-browser and upload-drop-body classes to Card, Avatar, Button, and Input wrappers
CardUpload.razor
AvatarUpload.razor
ButtonUpload.razor
InputUpload.razor
Adjust SCSS for drop-area positioning and overlay actions
  • Set upload-body to position: relative
  • Simplify .upload-item-plus and .upload-item-actions selectors
  • Use inset shorthand for absolute positioning of action overlays
InputUpload.razor.scss
Standardize Razor component tag syntax
  • Convert self-closing tags (BootstrapLabel, FileIcon, ImagePreviewer, InputFile) to explicit start/end syntax
CardUpload.razor
Refine JavaScript event handling and cleanup in upload module
  • Reformat try/catch block for upload drop event
  • Ensure complete removal of event listeners including input change
upload.js
Update CSS builder logic and unit tests for drop support
  • Extend GetItemClassString to accept custom classes
  • Include upload-drop-body in CardItemClass and BrowserButtonClassString
  • Adjust unit test assertions to match new class names
AvatarUpload.razor.cs
CardUpload.razor.cs
ButtonUpload.razor.cs
UploadAvatarTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6289 The CardUpload component should allow users to drag and drop files onto the card for uploading.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Jun 24, 2025
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 24, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) June 24, 2025 04:55
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jun 24, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang
Copy link
Member Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3a3b8cc) to head (906505c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          712       712           
  Lines        31397     31392    -5     
  Branches      4437      4437           
=========================================
- Hits         31397     31392    -5     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit efa9089 into main Jun 24, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-upload branch June 24, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(CardUpload): 更新新版本后拖拽文件到卡片上上传不了

2 participants