-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Upload): support drag/drop upload function #6290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideAdds drag-and-drop support across all upload components by marking drop zones in the markup and CSS, updating SCSS for overlay positioning, refining JavaScript event handling and disposal, and adjusting component class builders and tests to incorporate the new behavior. Class diagram for updated upload components with drag-and-drop supportclassDiagram
class CardUpload {
+string? CardItemClass
+RenderFragment RenderAdd
}
class AvatarUpload {
+string? GetItemClassString(string? classString = null)
+RenderFragment RenderAdd
}
class ButtonUpload {
+string? BrowserButtonClassString
}
CardUpload --|> UploadBase
AvatarUpload --|> UploadBase
ButtonUpload --|> UploadBase
class UploadBase {
<<abstract>>
}
Flow diagram for drag-and-drop event handling in upload.jsflowchart TD
A[User drags file over drop zone] --> B[Drop zone highlights]
B --> C[User drops file]
C --> D[JavaScript handles drop event]
D --> E[InputFile receives files]
E --> F[Change event triggered]
F --> G[File upload process starts]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6290 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 712 712
Lines 31397 31392 -5
Branches 4437 4437
=========================================
- Hits 31397 31392 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6289
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable drag-and-drop support across all Upload components by adding drop-zone classes, updating JavaScript event handling, and adjusting component markups and styles.
New Features:
Enhancements:
Tests: