Skip to content

fix(Tab): should not rerender tabitem after close #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2025
Merged

fix(Tab): should not rerender tabitem after close #6294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a80f814
refactor: 更改 Key 为 Guid
ArgoZhang Jun 24, 2025
4b450c1
refactor: 增加 wrap 样式
ArgoZhang Jun 24, 2025
8539759
refactor: 使用 Find 方法
ArgoZhang Jun 24, 2025
4749f51
fix: 修复关闭标签页导致后续标签页重绘问题
ArgoZhang Jun 24, 2025
4640099
chore: bump version 9.8.0-beta02
ArgoZhang Jun 24, 2025
25b6158
chore: bump version 9.8.0-beta03
ArgoZhang Jun 24, 2025
ee44cd1
Revert "chore: bump version 9.8.0-beta03"
ArgoZhang Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>9.8.0-beta01</Version>
<Version>9.8.0-beta02</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
8 changes: 6 additions & 2 deletions src/BootstrapBlazor/Components/Tab/Tab.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,18 @@ else
var item = TabItems.Find(i => i.IsActive);
if (item != null)
{
@RenderTabItem(item)
<div id="@item.Id" class="@GetTabItemClassString(item)">
@RenderTabItem(item)
</div>
}
}
else
{
foreach (var item in TabItems)
{
@RenderTabItem(item)
<div @key="@item" id="@item.Id" class="@GetTabItemClassString(item)">
Copy link
Contributor

@sourcery-ai sourcery-ai bot Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Adding @key to the div may affect Blazor's diffing behavior.

If item is a complex object, property changes may not trigger updates as expected. Using a unique, stable value like item.Id as the key is recommended.

@RenderTabItem(item)
</div>
}
}
</CascadingValue>
Expand Down
6 changes: 5 additions & 1 deletion src/BootstrapBlazor/Components/Tab/Tab.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,10 @@ public partial class Tab

private bool IsPreventDefault => _contextMenuZone != null;

private static string? GetTabItemClassString(TabItem item) => CssBuilder.Default("tabs-body-content")
.AddClass("d-none", item is { IsActive: false })
.Build();

/// <summary>
/// <inheritdoc/>
/// </summary>
Expand Down Expand Up @@ -1054,7 +1058,7 @@ public async Task DragItemCallback(int originIndex, int currentIndex)
private async Task OnRefreshAsync()
{
// refresh the active tab item
var item = TabItems.FirstOrDefault(i => i.IsActive);
var item = TabItems.Find(i => i.IsActive);

if (item is not null)
{
Expand Down
11 changes: 3 additions & 8 deletions src/BootstrapBlazor/Components/Tab/TabItemContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,13 @@ private void RenderContent()
_renderHandle.Render(BuildRenderTree);
}

private object _key = new();
private Guid _key = Guid.NewGuid();

private void BuildRenderTree(RenderTreeBuilder builder)
{
builder.OpenElement(0, "div");
builder.SetKey(_key);
builder.AddAttribute(5, "class", ClassString);
builder.AddAttribute(6, "id", Item.Id);
builder.AddAttribute(5, "class", "tabs-body-content-wrap");
builder.AddContent(10, RenderItemContent(Item.ChildContent));
builder.CloseElement();
}
Expand All @@ -79,16 +78,12 @@ private RenderFragment RenderItemContent(RenderFragment? content) => builder =>
builder.CloseComponent();
};

private string? ClassString => CssBuilder.Default("tabs-body-content")
.AddClass("d-none", !Item.IsActive)
.Build();

/// <summary>
/// Render method
/// </summary>
public void Render()
{
_key = new object();
_key = Guid.NewGuid();
RenderContent();
}

Expand Down
Loading