Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 3, 2025

Link issues

fixes #6348

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove the deprecated Coms demo page and associated assets to address issue #6348.

Chores:

  • Delete the Coms.razor page and its markup from the server components.
  • Remove the 'Components' menu entry from the navigation setup.
  • Clean up all related image files from the wwwroot/images directory.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jul 3, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 3, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 3, 2025

Reviewer's Guide

This PR removes the obsolete Coms documentation page and its related assets, cleans up the navigation menu by dropping the “Components” entry, and deletes all associated image files.

File-Level Changes

Change Details Files
Remove and strip Coms page implementation
  • Deleted @page directive and search/filter markup
  • Removed CascadingValue and all ComponentCategory/ComponentCard markup
  • Replaced entire page content with a flat list of image references
src/BootstrapBlazor.Server/Components/Pages/Coms.razor
Remove unused component image assets
  • Deleted dozens of SVG, PNG, JPG and GIF files from the images directory
  • Cleaned up obsolete asset files no longer referenced by any page
src/BootstrapBlazor.Server/wwwroot/images/*
Remove “Components” menu entry
  • Deleted DemoMenuItem instantiation for Components
  • Removed AddSummary call for the Components menu item
src/BootstrapBlazor.Server/Extensions/MenusLocalizerExtensions.cs

Assessment against linked issues

Issue Objective Addressed Explanation

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jul 3, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Coms.razor now contains only a list of image filenames—if the goal is to remove the page entirely, you should delete the file or replace it with a proper redirect/placeholder rather than leaving orphaned content.
  • Please update or remove any remaining navigation links and route registrations for "/components" to avoid dead or broken routes in the app.
  • Double-check that deleting all those image assets doesn’t inadvertently break any other components or demos that might still reference them.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Coms.razor now contains only a list of image filenames—if the goal is to remove the page entirely, you should delete the file or replace it with a proper redirect/placeholder rather than leaving orphaned content.
- Please update or remove any remaining navigation links and route registrations for "/components" to avoid dead or broken routes in the app.
- Double-check that deleting all those image assets doesn’t inadvertently break any other components or demos that might still reference them.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit ad6f782 into main Jul 3, 2025
3 of 4 checks passed
@ArgoZhang ArgoZhang deleted the doc-com branch July 3, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Coms): remove Coms page

2 participants