-
-
Notifications
You must be signed in to change notification settings - Fork 362
doc(Coms): remove Coms page #6349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR removes the obsolete Coms documentation page and its related assets, cleans up the navigation menu by dropping the “Components” entry, and deletes all associated image files. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Coms.razor now contains only a list of image filenames—if the goal is to remove the page entirely, you should delete the file or replace it with a proper redirect/placeholder rather than leaving orphaned content.
- Please update or remove any remaining navigation links and route registrations for "/components" to avoid dead or broken routes in the app.
- Double-check that deleting all those image assets doesn’t inadvertently break any other components or demos that might still reference them.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Coms.razor now contains only a list of image filenames—if the goal is to remove the page entirely, you should delete the file or replace it with a proper redirect/placeholder rather than leaving orphaned content.
- Please update or remove any remaining navigation links and route registrations for "/components" to avoid dead or broken routes in the app.
- Double-check that deleting all those image assets doesn’t inadvertently break any other components or demos that might still reference them.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6348
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the deprecated Coms demo page and associated assets to address issue #6348.
Chores: