-
-
Notifications
You must be signed in to change notification settings - Fork 362
test(ITcpSocketClient): improve code coverage #6356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideRefactored the handling of OperationCanceledException in TcpSocketClientBase by replacing the inline ternary log call with explicit if/else branches to clearly distinguish cancellation vs. timeout scenarios, improving testability and coverage. Class diagram for updated TcpSocketClientBase exception handlingclassDiagram
class TcpSocketClientBase {
+ValueTask<bool> SendAsync(ReadOnlyMemory<byte> data, CancellationToken token)
-Log(LogLevel, Exception, string)
}
TcpSocketClientBase : SendAsync() handles OperationCanceledException
TcpSocketClientBase : Log() called with different messages for cancellation vs timeout
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6356 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 718 718
Lines 31572 31607 +35
Branches 4461 4461
=======================================
+ Hits 31571 31606 +35
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6355
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve test coverage for ITcpSocketClient by refactoring the SendAsync catch block to allow distinct logging for cancellation and timeout cases and adding corresponding unit tests.
Enhancements:
Tests: