- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 362
 
fix(Progress): culture causes decimal points to be changed to commas #6362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
Reviewer's GuideThis PR addresses culture-specific formatting in the Progress component by using an invariant culture string conversion for the width style and updates the sample to demonstrate fractional values. Class diagram for Progress component formatting changeclassDiagram
    class Progress {
        - double InternalValue
        + string? StyleName
    }
    Progress : StyleName uses InternalValue.ToString(CultureInfo.InvariantCulture)
    File-Level Changes
 Assessment against linked issues
 Possibly linked issues
 Tips and commandsInteracting with Sourcery
 Customizing Your ExperienceAccess your dashboard to: 
 Getting Help
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Consider specifying a fixed format (e.g. 
InternalValue.ToString("F2", CultureInfo.InvariantCulture)) to avoid overly long decimal representations in the inline width style. - Using 
.AddClassto emit inline styles can be confusing—consider switching to.AddStyleor a dedicated CSS class for the width property for better maintainability. 
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider specifying a fixed format (e.g. `InternalValue.ToString("F2", CultureInfo.InvariantCulture)`) to avoid overly long decimal representations in the inline width style.
- Using `.AddClass` to emit inline styles can be confusing—consider switching to `.AddStyle` or a dedicated CSS class for the width property for better maintainability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff            @@
##              main     #6362   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          718       718           
  Lines        31608     31608           
  Branches      4461      4461           
=========================================
  Hits         31608     31608           
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
Link issues
fixes #6354
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix culture-specific decimal separator in Progress component and update sample to show fractional values.
Bug Fixes:
Enhancements: