Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 10, 2025

Link issues

fixes #6383

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove obsolete SortList snippet from the TablesFilter sample and streamline its sorting logic to rely solely on built-in name/order handling

Bug Fixes:

Enhancements:

  • Simplify sample sorting code to use only options.SortName and options.SortOrder

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jul 10, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 10, 2025

Reviewer's Guide

This PR streamlines the sample Table component by removing redundant manual sort list handling and relying solely on the built-in Sort method using SortName and SortOrder.

File-Level Changes

Change Details Files
Removed manual SortList handling and simplified sorting logic
  • Deleted conditional block checking DateTime sort with SortList
  • Removed associated comments explaining internal handling
  • Replaced detailed SortList branch with a single Sort(SortName, SortOrder) call
src/BootstrapBlazor.Server/Components/Samples/Table/TablesFilter.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6383 Remove the SortList sample code from the Table component documentation.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 10, 2025
@ArgoZhang ArgoZhang merged commit 6943615 into main Jul 10, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the doc-filter branch July 10, 2025 04:07
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (b84dd4c) to head (9f18998).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6384   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         718      718           
  Lines       31686    31686           
  Branches     4471     4471           
=======================================
  Hits        31681    31681           
  Misses          4        4           
  Partials        1        1           
Flag Coverage Δ
BB 99.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Table): remove SortList sample

2 participants