-
-
Notifications
You must be signed in to change notification settings - Fork 362
doc(Table): remove SortList sample #6384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR streamlines the sample Table component by removing redundant manual sort list handling and relying solely on the built-in Sort method using SortName and SortOrder. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6384 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 718 718
Lines 31686 31686
Branches 4471 4471
=======================================
Hits 31681 31681
Misses 4 4
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6383
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove obsolete SortList snippet from the TablesFilter sample and streamline its sorting logic to rely solely on built-in name/order handling
Bug Fixes:
Enhancements: