feat(ITcpSocketClient): add OnConnecting callback #6392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR introduces OnConnecting and OnConnected hooks to the TCP client API, refactors connection cleanup and auto-reconnect flows in DefaultTcpSocketClient, enhances disconnection detection and logging, adds a Blazor auto-reconnect demo with a mock disconnect server, and expands unit tests to cover the new callbacks and disconnect scenarios. Sequence diagram for TCP client connection with OnConnecting and OnConnected hookssequenceDiagram
participant User as actor User
participant Client as DefaultTcpSocketClient
participant Server as TcpServer
User->>Client: ConnectAsync()
alt OnConnecting callback set
Client->>Client: await OnConnecting()
end
Client->>Server: Establish TCP connection
alt OnConnected callback set
Client->>Client: await OnConnected()
end
Server-->>Client: Connection established
Class diagram for ITcpSocketClient and DefaultTcpSocketClient with new connection callbacksclassDiagram
class ITcpSocketClient {
+Func<ReadOnlyMemory<byte>, ValueTask>? ReceivedCallBack
+Func<Task>? OnConnecting
+Func<Task>? OnConnected
+ValueTask<bool> ConnectAsync(IPEndPoint, CancellationToken)
+ValueTask CloseAsync()
}
class DefaultTcpSocketClient {
+Func<ReadOnlyMemory<byte>, ValueTask>? ReceivedCallBack
+Func<Task>? OnConnecting
+Func<Task>? OnConnected
+ValueTask<bool> ConnectAsync(IPEndPoint, CancellationToken)
+ValueTask CloseAsync()
-ValueTask CloseCoreAsync()
-void Reconnect()
-void Log(LogLevel, Exception?, string?)
}
ITcpSocketClient <|.. DefaultTcpSocketClient
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Ensure existing _autoConnectTokenSource is cancelled and disposed before reassigning a new one in ConnectAsync to avoid leaking cancellation tokens.
- Wrap invocations of OnConnecting and OnConnected in try/catch blocks so that exceptions in user callbacks don’t break the connection flow.
- Move MockDisconnectServerService under the BootstrapBlazor.Server.Services namespace (instead of Longbow.Tasks.Services) to keep project namespace consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure existing _autoConnectTokenSource is cancelled and disposed before reassigning a new one in ConnectAsync to avoid leaking cancellation tokens.
- Wrap invocations of OnConnecting and OnConnected in try/catch blocks so that exceptions in user callbacks don’t break the connection flow.
- Move MockDisconnectServerService under the BootstrapBlazor.Server.Services namespace (instead of Longbow.Tasks.Services) to keep project namespace consistency.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6392 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 718 718
Lines 31712 31729 +17
Branches 4473 4477 +4
=========================================
+ Hits 31712 31729 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6391
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add OnConnecting and OnConnected callbacks around the TCP client connection process, refine auto-reconnect and resource cleanup logic, update logging behavior, introduce an auto-reconnect sample with mock disconnect server, and extend unit tests accordingly.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: