Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 11, 2025

Link issues

fixes #6398

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Disable table editing features (add, edit, inline row edits, and insert-row UI) when virtual scrolling is enabled.

Enhancements:

  • Hide Add and Edit toolbar buttons unless scroll mode is None
  • Skip rendering insert-row forms and cell insertion when in virtual scroll mode
  • Disable inline row edit buttons for virtual scroll mode

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 11, 2025

Reviewer's Guide

This PR disables all editing features when the table is in Virtual scroll mode by adding ScrollMode checks to toolbar buttons and code-behind logic, and by restructuring the row rendering so insert forms/rows only render in non-virtual scroll mode.

Class diagram for Table editing controls with ScrollMode

classDiagram
    class Table {
        +ScrollMode ScrollMode
        +bool ShowAddButton
        +bool ShowEditButton
        +bool ShowExtendEditButton
        +bool GetShowExtendEditButton(TItem item)
        +RenderEditForm
        +RenderRow
    }
    class ScrollMode {
        <<enum>>
        None
        Virtual
    }
    Table --> ScrollMode
    Table : GetShowExtendEditButton() now disables in Virtual mode
    Table : Add/Edit buttons only enabled if ScrollMode==None
    Table : Insert forms/rows only rendered if ScrollMode==None
Loading

Flow diagram for Table row rendering with Virtual ScrollMode

flowchart TD
    A[Start Table Render] --> B{ScrollMode == Virtual?}
    B -- Yes --> C[Render only Items rows]
    C --> D[No Insert/Edit forms or AddInCell rows]
    B -- No --> E{InsertRowMode == First?}
    E -- Yes --> F[Render Insert/Edit forms or AddInCell rows at top]
    E -- No --> G{InsertRowMode == Last?}
    G -- Yes --> H[Render Insert/Edit forms or AddInCell rows at bottom]
    G -- No --> I[Render normal Rows]
    F --> I
    H --> I
    I --> J[Render Empty Row if needed]
    C --> J
Loading

File-Level Changes

Change Details Files
Conditionally hide Add and Edit toolbar buttons in virtual scroll mode
  • Add '&& ScrollMode == ScrollMode.None' to the ShowAddButton check
  • Add '&& ScrollMode == ScrollMode.None' to the ShowEditButton check
Table.razor
Restrict insert-row rendering to non-virtual scroll mode
  • Remove the standalone InsertRowMode First block at the top of tbody
  • Move both InsertRowMode First and Last rendering inside the non-virtual branch
  • Remove the InsertRowMode Last block at the bottom of tbody
Table.razor
Disable inline edit button when in virtual scroll mode
  • Update GetShowExtendEditButton to return false if ScrollMode == ScrollMode.Virtual
Table.razor.Toolbar.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6398 Disable editing functionality in the Table component when virtual scroll mode is enabled.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jul 11, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 11, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jul 11, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c70eca9) to head (05034f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6399   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          718       718           
  Lines        31729     31729           
  Branches      4477      4477           
=========================================
  Hits         31729     31729           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 2f59a8d into main Jul 11, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the refactor-table branch July 11, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): disable editing in virtual scroll mode

2 participants