-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Table): disable editing in virtual scroll mode #6399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR disables all editing features when the table is in Virtual scroll mode by adding ScrollMode checks to toolbar buttons and code-behind logic, and by restructuring the row rendering so insert forms/rows only render in non-virtual scroll mode. Class diagram for Table editing controls with ScrollModeclassDiagram
class Table {
+ScrollMode ScrollMode
+bool ShowAddButton
+bool ShowEditButton
+bool ShowExtendEditButton
+bool GetShowExtendEditButton(TItem item)
+RenderEditForm
+RenderRow
}
class ScrollMode {
<<enum>>
None
Virtual
}
Table --> ScrollMode
Table : GetShowExtendEditButton() now disables in Virtual mode
Table : Add/Edit buttons only enabled if ScrollMode==None
Table : Insert forms/rows only rendered if ScrollMode==None
Flow diagram for Table row rendering with Virtual ScrollModeflowchart TD
A[Start Table Render] --> B{ScrollMode == Virtual?}
B -- Yes --> C[Render only Items rows]
C --> D[No Insert/Edit forms or AddInCell rows]
B -- No --> E{InsertRowMode == First?}
E -- Yes --> F[Render Insert/Edit forms or AddInCell rows at top]
E -- No --> G{InsertRowMode == Last?}
G -- Yes --> H[Render Insert/Edit forms or AddInCell rows at bottom]
G -- No --> I[Render normal Rows]
F --> I
H --> I
I --> J[Render Empty Row if needed]
C --> J
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-Authored-By: shakugans <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6399 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 718 718
Lines 31729 31729
Branches 4477 4477
=========================================
Hits 31729 31729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6398
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Disable table editing features (add, edit, inline row edits, and insert-row UI) when virtual scrolling is enabled.
Enhancements: