-
-
Notifications
You must be signed in to change notification settings - Fork 362
test(IThrottleDispatcherFactory): improve code coverage #6411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideRefactors ThrottleDispatcher methods by simplifying internal async/sync throttle logic and cancellation handling, and removes an outdated cancellation test to improve coverage. Class diagram for updated ThrottleDispatcher methodsclassDiagram
class ThrottleDispatcher {
+ThrottleDispatcher(ThrottleOptions options)
+Task ThrottleAsync(Func<Task> function, CancellationToken cancellationToken = default)
+void Throttle(Action action, CancellationToken token = default)
-Task InternalThrottleAsync(Func<Task> function, CancellationToken cancellationToken)
}
ThrottleDispatcher : ThrottleAsync simplified to call InternalThrottleAsync directly with function
ThrottleDispatcher : Throttle simplified to call InternalThrottleAsync and wait synchronously
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6411 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 722 722
Lines 31832 31832
Branches 4490 4490
=======================================
Hits 31831 31831
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6410
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Simplify ThrottleDispatcher methods to eliminate redundant Task.Run wrappers and clean up obsolete tests
Enhancements:
Tests: