Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 16, 2025

Link issues

fixes #6426

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update Chinese README to refine MVP listings and expand ecosystem partnerships

Documentation:

  • Include Guohao Wang’s MVP term (2023–2025) in the MVP list
  • Rename the “生态伙伴” section to “生态伙伴 WTM” and add a new “生态伙伴 ThingsGateway” partner entry with description and logo

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jul 16, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 16, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 16, 2025

Reviewer's Guide

This PR updates the Chinese README by annotating an existing partner entry and introducing a new ThingsGateway ecosystem partner section with descriptive content and assets.

File-Level Changes

Change Details Files
Annotated an existing partner entry
  • Added active years “(2023-2025)” to Guohao Wang’s listing
README.zh-CN.md
Scoped the original ecosystem partners under WTM
  • Renamed the second-level heading from “生态伙伴” to “生态伙伴 WTM”
README.zh-CN.md
Added a new ThingsGateway ecosystem partner section
  • Introduced a new heading “生态伙伴 ThingsGateway”
  • Provided a descriptive overview of ThingsGateway’s features
  • Embedded link and logo image markup for ThingsGateway
  • Outlined modular capabilities and UI integration details
README.zh-CN.md

Assessment against linked issues

Issue Objective Addressed Explanation
#6426 Add sample code for the specified component to the documentation. The issue asks for sample code, but the PR only adds ecosystem partners to the README.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 3570038 into main Jul 16, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the doc-readme branch July 16, 2025 07:42
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Duplicated 'https://' in the image link URL. (link)

General comments:

  • You have duplicated the entire WTM 快速开发框架 block twice—please remove one of them to avoid redundancy.
  • The ThingsGateway link has a malformed URL (https://https://thingsgateway.cn/); please correct it to https://thingsgateway.cn/.
  • Consider standardizing your section headers (e.g. use the same ‘## 生态伙伴’ format for each partner) to keep the README structure consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You have duplicated the entire WTM 快速开发框架 block twice—please remove one of them to avoid redundancy.
- The ThingsGateway link has a malformed URL (`https://https://thingsgateway.cn/`); please correct it to `https://thingsgateway.cn/`.
- Consider standardizing your section headers (e.g. use the same ‘## 生态伙伴’ format for each partner) to keep the README structure consistent.

## Individual Comments

### Comment 1
<location> `README.zh-CN.md:49` </location>
<code_context>
+## 生态伙伴 ThingsGateway
+ThingsGateway 边缘网关,致力于打造“高性能、插件扩展、易集成”的工业物联网网关解决方案。
+
+<a href="https://https://thingsgateway.cn/" target="_blank"><img src="https://foruda.gitee.com/images/1752651511062082157/c6a923f8_554725.png" width="100px" /></a>
+
+ThingsGateway 将设备接入、数据上传等功能模块化,降低工业协议开发门槛,自动处理线程调度与数据缓存,极大提升开发效率与系统稳定性。
</code_context>

<issue_to_address>
Duplicated 'https://' in the image link URL.

Please update the URL to 'https://thingsgateway.cn/' to fix the broken link.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

## 生态伙伴 ThingsGateway
ThingsGateway 边缘网关,致力于打造“高性能、插件扩展、易集成”的工业物联网网关解决方案。

<a href="https://https://thingsgateway.cn/" target="_blank"><img src="https://foruda.gitee.com/images/1752651511062082157/c6a923f8_554725.png" width="100px" /></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Duplicated 'https://' in the image link URL.

Please update the URL to 'https://thingsgateway.cn/' to fix the broken link.

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ab6431b) to head (234c3d1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6427   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        32225     32225           
  Branches      4554      4554           
=========================================
  Hits         32225     32225           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(readme): add TG ecosystem Partners

2 participants