feat(SocketDataConveter): remove abstract keyword #6447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR replaces the abstract SocketDataConverterBase with a concrete generic SocketDataConverter (providing a default TryConvertTo and CreateEntity implementation), introduces a DataPackageAdapter abstraction in client samples to replace direct SetDataHandler usage, updates tests and sample components to reference the new converter and adapter types, and applies several minor C# syntax and style cleanups. Class diagram for SocketDataConverter replacing SocketDataConverterBaseclassDiagram
class ISocketDataConverter~TEntity~ {
<<interface>>
+bool TryConvertTo(ReadOnlyMemory<byte> data, out TEntity? entity)
}
class SocketDataConverter~TEntity~ {
+bool TryConvertTo(ReadOnlyMemory<byte> data, out TEntity? entity)
+TEntity CreateEntity()
+bool Parse(ReadOnlyMemory<byte> data, TEntity entity)
}
ISocketDataConverter~TEntity~ <|.. SocketDataConverter~TEntity~
Class diagram for DataPackageAdapter usage in client samplesclassDiagram
class DataPackageAdapter {
+FixLengthDataPackageHandler DataPackageHandler
+event ReceivedCallBack(ReadOnlyMemory<byte> data)
}
class FixLengthDataPackageHandler {
+int Length
}
DataPackageAdapter o-- FixLengthDataPackageHandler : uses
Class diagram for SocketClientOptions minor property updateclassDiagram
class SocketClientOptions {
+IPEndPoint LocalEndPoint
+bool EnableLog
+bool IsAutoReconnect
}
class IPEndPoint
SocketClientOptions o-- IPEndPoint : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Services/TcpSocket/DataConverter/SocketDataConverterBase.cs:34` </location>
<code_context>
+ /// 创建实体实例方法
+ /// </summary>
+ /// <returns></returns>
+ protected virtual TEntity CreateEntity() => Activator.CreateInstance<TEntity>();
/// <summary>
</code_context>
<issue_to_address>
Using Activator.CreateInstance may throw if TEntity lacks a parameterless constructor.
Document the requirement for a public parameterless constructor or handle instantiation for types that lack one.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/BootstrapBlazor/Services/TcpSocket/DataConverter/SocketDataConverterBase.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 748 748
Lines 32259 32266 +7
Branches 4560 4561 +1
=========================================
+ Hits 32259 32266 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6446
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the abstract socket data converter base class in favor of a concrete generic SocketDataConverter, update adapter and sample code to use the new converter, and enhance examples and tests for attribute-driven data adaptation.
Bug Fixes:
Enhancements:
Documentation:
Tests: