Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 20, 2025

Link issues

fixes #6450

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Use ValidateForm for form validation and submission in all login templates to improve consistency and address issue #6450

Enhancements:

  • Wrap login inputs in ValidateForm and bind OnValidSubmit handlers in all sample templates
  • Convert login buttons to submit types and implement corresponding OnSubmit/OnEmailSubmit/OnPasswordSubmit callbacks
  • Introduce a unified LoginModel in Template5 to manage email and password fields and replace individual variables

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jul 20, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 20, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 20, 2025

Reviewer's Guide

This PR refactors the login samples to adopt the ValidateForm component uniformly, replacing ad-hoc input validation and click handlers with form-level validation callbacks and model binding.

Class diagram for updated login form model usage

classDiagram
    class LoginModel {
        string? Email
        string? Password
    }
    class Template1
    class Template2
    class Template3
    class Template4
    class Template5
    Template1 --> LoginModel : uses
    Template2 --> LoginModel : uses
    Template3 --> LoginModel : uses
    Template4 --> LoginModel : uses
    Template5 --> LoginModel : uses
    class ValidateForm {
        +Model
        +OnValidSubmit(EditContext)
    }
    Template1 --> ValidateForm : uses
    Template2 --> ValidateForm : uses
    Template3 --> ValidateForm : uses
    Template4 --> ValidateForm : uses
    Template5 --> ValidateForm : uses
Loading

File-Level Changes

Change Details Files
Refactor Template5 to use form validation with a shared model
  • Wrap email and password steps in ValidateForm with OnValidSubmit handlers
  • Introduce LoginModel for Email/Password and remove separate string fields
  • Convert OnEmailSubmit/OnPasswordSubmit to Task handlers that accept EditContext
  • Update Buttons to Submit type and bind inputs to LoginModel
Template5.razor
Standardize ValidateForm usage in Templates 1–4
  • Add OnValidSubmit="OnSubmit" to all ValidateForm instances
  • Change primary Buttons to ButtonType.Submit
  • Implement OnSubmit(EditContext) methods calling StateHasChanged
  • Minor input tweaks (IsAutoFocus, placeholder adjustments)
Template1.razor
Template2.razor
Template3.razor
Template4.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6450 Update the LoginTemplate (login form) to use the ValidateForm component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Template5’s final “进入” button no longer has an event handler—add an OnClick or wrap it in a ValidateForm with OnValidSubmit to invoke your submit logic.
  • Since you’re using ValidateForm, decorate LoginModel properties with DataAnnotations (e.g. [Required], [EmailAddress]) and remove SkipValidate so you can rely on built-in validation instead of manual flags.
  • The OnSubmit handlers in Templates1–4 all just call StateHasChanged; consider extracting this repetitive logic into a shared base component or helper method to DRY up the code.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Template5’s final “进入” button no longer has an event handler—add an OnClick or wrap it in a ValidateForm with OnValidSubmit to invoke your submit logic.
- Since you’re using ValidateForm, decorate LoginModel properties with DataAnnotations (e.g. [Required], [EmailAddress]) and remove SkipValidate so you can rely on built-in validation instead of manual flags.
- The OnSubmit handlers in Templates1–4 all just call StateHasChanged; consider extracting this repetitive logic into a shared base component or helper method to DRY up the code.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 1008101 into main Jul 20, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-login branch July 20, 2025 07:40
@codecov
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a324fe4) to head (7e436a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          749       749           
  Lines        32359     32359           
  Branches      4571      4571           
=========================================
  Hits         32359     32359           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(LoginTemplate): use ValidateForm in login form

2 participants