-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(TabItem): layout OnErrorHandleAsync callback not work on tab item #6461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR fixes the missing wiring of the global OnErrorHandleAsync callback for TabItem components by cascading the Layout context into TabItemContent and passing its error handler to the ErrorLogger, and also updates the XML doc comment for the EnableErrorLogger parameter to reference the correct configuration option. Class diagram for updated TabItemContent and related error handlingclassDiagram
class TabItemContent {
+TabItem Item
-Layout Layout
-Tab TabSet
BuildRenderTree(RenderTreeBuilder builder)
}
class Layout {
+OnErrorHandleAsync
}
class ErrorLogger {
+OnErrorHandleAsync
}
TabItemContent --> Layout : CascadingParameter
TabItemContent --> Tab : CascadingParameter
TabItemContent ..> ErrorLogger : Passes OnErrorHandleAsync
Layout --> ErrorLogger : OnErrorHandleAsync
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6461 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 749 749
Lines 32359 32361 +2
Branches 4571 4572 +1
===========================================
+ Hits 32359 32360 +1
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6460
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Ensure TabItemContent correctly propagates the Layout.OnErrorHandleAsync callback for global error handling and update documentation for EnableErrorLogger default reference.
Bug Fixes:
Enhancements:
Documentation: