Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 22, 2025

Link issues

fixes #6460

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Ensure TabItemContent correctly propagates the Layout.OnErrorHandleAsync callback for global error handling and update documentation for EnableErrorLogger default reference.

Bug Fixes:

  • Fix layout OnErrorHandleAsync callback not invoked on tab items

Enhancements:

  • Pass Layout.OnErrorHandleAsync to ErrorLogger in TabItemContent for consistent error handling

Documentation:

  • Clarify default reference for EnableErrorLogger to BootstrapBlazorOptions.EnableErrorLogger in Tab component

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 22, 2025

Reviewer's Guide

This PR fixes the missing wiring of the global OnErrorHandleAsync callback for TabItem components by cascading the Layout context into TabItemContent and passing its error handler to the ErrorLogger, and also updates the XML doc comment for the EnableErrorLogger parameter to reference the correct configuration option.

Class diagram for updated TabItemContent and related error handling

classDiagram
    class TabItemContent {
        +TabItem Item
        -Layout Layout
        -Tab TabSet
        BuildRenderTree(RenderTreeBuilder builder)
    }
    class Layout {
        +OnErrorHandleAsync
    }
    class ErrorLogger {
        +OnErrorHandleAsync
    }
    TabItemContent --> Layout : CascadingParameter
    TabItemContent --> Tab : CascadingParameter
    TabItemContent ..> ErrorLogger : Passes OnErrorHandleAsync
    Layout --> ErrorLogger : OnErrorHandleAsync
Loading

File-Level Changes

Change Details Files
Propagate Layout.OnErrorHandleAsync callback into TabItemContent
  • Added Layout as a cascading parameter
  • Bound Layout.OnErrorHandleAsync to the ErrorLogger.OnErrorHandleAsync attribute in BuildRenderTree
src/BootstrapBlazor/Components/Tab/TabItemContent.cs
Enhance XML documentation for EnableErrorLogger
  • Updated summary comment to reference BootstrapBlazorOptions.EnableErrorLogger via
src/BootstrapBlazor/Components/Tab/Tab.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6460 Fix the bug where the OnErrorHandleAsync callback does not work in TabItem.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Jul 22, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 22, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (373f5c7) to head (2768a48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #6461      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          749      749              
  Lines        32359    32361       +2     
  Branches      4571     4572       +1     
===========================================
+ Hits         32359    32360       +1     
- Partials         0        1       +1     
Flag Coverage Δ
BB 99.99% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit bbae67e into main Jul 22, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the fix-tab branch July 22, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(TabItem): OnErrorHandleAsync not work

2 participants