-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Collapse): redesign HeaderTemplate function #6467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR redesigns the Collapse component’s header template handling by consolidating template, icon, and text rendering into the header button for clearer conditional logic, and streamlines sample usage by removing unnecessary wrappers. Class diagram for updated Collapse component header renderingclassDiagram
class CollapseItem {
+string Text
+string Icon
+RenderFragment HeaderTemplate
+bool IsCollapsed
}
class Collapse {
+List<CollapseItem> Items
+string GetHeaderButtonClassString(CollapseItem)
+string GetHeaderClassString(CollapseItem)
+string GetItemClassString(CollapseItem)
+string GetItemIconString(CollapseItem)
+string GetTargetIdString(CollapseItem)
+string GetTargetId(CollapseItem)
+string GetClassString(bool)
+void OnClickItem(CollapseItem)
}
Collapse "1" o-- "many" CollapseItem: contains
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6467 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 32362 32364 +2
Branches 4572 4572
=========================================
+ Hits 32362 32364 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6466
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Redesign the Collapse component's HeaderTemplate to render inside the header button and prioritize it over icons and text, and update sample usage accordingly
Enhancements: