Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 22, 2025

Link issues

fixes #6466

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Redesign the Collapse component's HeaderTemplate to render inside the header button and prioritize it over icons and text, and update sample usage accordingly

Enhancements:

  • Render HeaderTemplate inside the collapse header button and adjust display priority over icons and text
  • Streamline sample usage by removing unnecessary wrapper divs around HeaderTemplate

@bb-auto bb-auto bot added the enhancement New feature or request label Jul 22, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 22, 2025

Reviewer's Guide

This PR redesigns the Collapse component’s header template handling by consolidating template, icon, and text rendering into the header button for clearer conditional logic, and streamlines sample usage by removing unnecessary wrappers.

Class diagram for updated Collapse component header rendering

classDiagram
    class CollapseItem {
        +string Text
        +string Icon
        +RenderFragment HeaderTemplate
        +bool IsCollapsed
    }
    class Collapse {
        +List<CollapseItem> Items
        +string GetHeaderButtonClassString(CollapseItem)
        +string GetHeaderClassString(CollapseItem)
        +string GetItemClassString(CollapseItem)
        +string GetItemIconString(CollapseItem)
        +string GetTargetIdString(CollapseItem)
        +string GetTargetId(CollapseItem)
        +string GetClassString(bool)
        +void OnClickItem(CollapseItem)
    }
    Collapse "1" o-- "many" CollapseItem: contains
Loading

File-Level Changes

Change Details Files
Refactor header rendering logic in Collapse component
  • Move HeaderTemplate rendering inside the header button element
  • Add conditional: if HeaderTemplate, else if Icon, else display Text
  • Remove previous separate rendering of HeaderTemplate and Text
src/BootstrapBlazor/Components/Collapse/Collapse.razor
Simplify sample HeaderTemplate usage
  • Remove redundant
    wrappers around HeaderTemplate content
  • Render Select and text directly without extra markup
src/BootstrapBlazor.Server/Components/Samples/Collapses.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6466 Redesign the HeaderTemplate function in the Collapse component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 22, 2025
@ArgoZhang ArgoZhang merged commit ddc61cd into main Jul 22, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-collapse branch July 22, 2025 10:09
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e862e75) to head (b590220).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6467   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          749       749           
  Lines        32362     32364    +2     
  Branches      4572      4572           
=========================================
+ Hits         32362     32364    +2     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Collapse): redesign HeaderTemplate function

2 participants