Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 25, 2025

Link issues

fixes #6487

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the CodeEditor sample to provide initial code snippets, simplify state handling with bindable selects, and display a live editor demo

Enhancements:

  • Initialize the CodeEditor sample with default code, language, and theme values
  • Switch language and theme selects to use @bind-Value instead of manual change handlers
  • Remove the redundant theme change handler method
  • Add a live CodeEditor preview inside a styled container in the sample view

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jul 25, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 25, 2025

Reviewer's Guide

This PR enriches the CodeEditor demo with default sample code snippets, replaces nullable properties with initialized private fields, streamlines selection handlers, and updates the markup to bind the new fields and render a live editor preview.

Class diagram for updated CodeEditors component

classDiagram
    class CodeEditors {
        - string _code = "sample code"
        - string _language = "CSharp"
        - string _theme = "vs"
        + Task OnSelectedItemChanged(SelectedItem item)
    }
Loading

File-Level Changes

Change Details Files
Initialize default code, language, and theme via private fields
  • Introduce _code, _language, and _theme fields with initial C# snippet and theme values
  • Remove nullable Code, Language, and Theme properties
CodeEditors.razor.cs
Refactor OnSelectedItemChanged handler
  • Update only _code based on selected language
  • Remove state change calls for Language and Theme
CodeEditors.razor.cs
Remove OnThemeSelectedItemChanged method
  • Delete obsolete theme selection logic and state updates
CodeEditors.razor.cs
Update demo markup to bind new fields and show live editor
  • Switch Select components to use @bind-Value for _language and _theme
  • Adjust Pre tag to display binding expressions for new fields
  • Add a live CodeEditor component preview with bound fields
CodeEditors.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6487 Add sample code for the CodeEditor component in the documentation or demo.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 25, 2025
@ArgoZhang ArgoZhang merged commit b6d1fee into main Jul 25, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the doc-code branch July 25, 2025 04:35
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/CodeEditors.razor:30` </location>
<code_context>
         </div>
         <div class="col-12">
-            <Pre>&lt;CodeEditor Value="@@Code" Language="@@Language" Theme="@@Theme" OnValueChanged="OnValueChanged" /&gt;</Pre>
+            <Pre>&lt;CodeEditor Value="@@_code" Language="@@_language" Theme="@@_theme" /&gt;</Pre>
+        </div>
+        <div class="col-12">
</code_context>

<issue_to_address>
The Pre block now uses the new backing fields, but the double @ may be unnecessary.

Ensure that using @@_code, @@_language, and @@_theme achieves the intended output. Use a single @ for interpolation, or verify proper escaping if displaying as a string.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

</div>
<div class="col-12">
<Pre>&lt;CodeEditor Value="@@Code" Language="@@Language" Theme="@@Theme" OnValueChanged="OnValueChanged" /&gt;</Pre>
<Pre>&lt;CodeEditor Value="@@_code" Language="@@_language" Theme="@@_theme" /&gt;</Pre>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: The Pre block now uses the new backing fields, but the double @ may be unnecessary.

Ensure that using @@_code, @@_language, and @@_theme achieves the intended output. Use a single @ for interpolation, or verify proper escaping if displaying as a string.

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6b73e28) to head (692d6e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6488   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          714       714           
  Lines        31383     31383           
  Branches      4431      4431           
=========================================
  Hits         31383     31383           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(CodeEditor): add sample cdoe for CodeEditor

2 participants