-
-
Notifications
You must be signed in to change notification settings - Fork 362
doc(QQGroup): update the DOM layout #6492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideSimplifies the QQGroup component's DOM structure by separating the QQ icon and group ID text into independent spans for both Group1 and Group2 links. Class diagram for updated QQGroup component DOM structureclassDiagram
class QQGroup {
+string QQGroup1Link
+string QQGroup2Link
+Render()
}
QQGroup : <<UI Component>>
QQGroup : - span.fa-qq (icon)
QQGroup : - span (group id text)
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6492 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31383 31383
Branches 4431 4431
=========================================
Hits 31383 31383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6491
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the QQGroup component markup to improve the DOM structure by separating the QQ icon and group ID into distinct spans, fixing layout issues (#6491).
Bug Fixes:
Enhancements: