refactor(NetworkMonitor): add try/finally keep release simaphore slim #6496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideEnsure the semaphore is always released by wrapping the network module initialization in a try/finally and removing the redundant release outside the block. Sequence diagram for semaphore handling in RegisterStateChangedCallbacksequenceDiagram
participant Component
participant DefaultNetworkMonitorService
participant SemaphoreSlim
participant NetworkModule
Component->>DefaultNetworkMonitorService: RegisterStateChangedCallback()
DefaultNetworkMonitorService->>SemaphoreSlim: WaitAsync(3000)
alt !_init
DefaultNetworkMonitorService->>DefaultNetworkMonitorService: try
DefaultNetworkMonitorService->>NetworkModule: LoadModuleByName("net")
NetworkModule-->>DefaultNetworkMonitorService: Module instance
DefaultNetworkMonitorService->>NetworkModule: InvokeVoidAsync("init", ...)
DefaultNetworkMonitorService->>SemaphoreSlim: finally Release()
else _init
DefaultNetworkMonitorService->>SemaphoreSlim: Release()
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Services/DefaultNetworkMonitorService.cs:61` </location>
<code_context>
if (!_init)
{
- _init = true;
+ try
+ {
+ _init = true;
- _networkModule ??= await _runtime.LoadModuleByName("net");
- await _networkModule.InvokeVoidAsync("init", new
+ _networkModule ??= await _runtime.LoadModuleByName("net");
+ await _networkModule.InvokeVoidAsync("init", new
+ {
+ Invoke = _interop,
+ OnNetworkStateChangedCallback = nameof(TriggerNetworkStateChanged)
+ });
+ }
+ finally
{
- Invoke = _interop,
</code_context>
<issue_to_address>
The try/finally block now only releases the semaphore if _init was false.
If _init is true, the semaphore is not released, which may cause deadlocks on subsequent RegisterStateChangedCallback calls. Ensure _semaphoreSlim.Release() is always called to prevent this.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+61
to
+70
| try | ||
| { | ||
| _init = true; | ||
|
|
||
| _networkModule ??= await _runtime.LoadModuleByName("net"); | ||
| await _networkModule.InvokeVoidAsync("init", new | ||
| _networkModule ??= await _runtime.LoadModuleByName("net"); | ||
| await _networkModule.InvokeVoidAsync("init", new | ||
| { | ||
| Invoke = _interop, | ||
| OnNetworkStateChangedCallback = nameof(TriggerNetworkStateChanged) | ||
| }); |
There was a problem hiding this comment.
issue (bug_risk): The try/finally block now only releases the semaphore if _init was false.
If _init is true, the semaphore is not released, which may cause deadlocks on subsequent RegisterStateChangedCallback calls. Ensure _semaphoreSlim.Release() is always called to prevent this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6496 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 714
Lines ? 31387
Branches ? 4431
========================================
Hits ? 31387
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6495
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Ensure DefaultNetworkMonitorService always releases its semaphore by wrapping the initialization logic in a try/finally and removing redundant Release calls.
Bug Fixes:
Enhancements: