-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Badge): use text-bg-color class #6501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request updates the Badge component to use the Bootstrap 5 “text-bg-*” background utility classes by adjusting both the style definitions and the Razor component’s CSS builder logic. Class diagram for updated Badge component CSS class logicclassDiagram
class Badge {
- string? ClassString
}
class CssBuilder {
+Default(string)
+AddClass(string, bool)
+AddClassFromAttributes(object)
+Build()
}
Badge --> CssBuilder : uses
%% Highlight the change in ClassString logic
%% Old: .AddClass($"bg-{Color.ToDescriptionString()}", Color != Color.None)
%% New: .AddClass($"text-bg-{Color.ToDescriptionString()}", Color != Color.None)
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Link issues
fixes #6500
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Switch Badge component styling to use Bootstrap’s text-bg-{color} utility classes for background colors
New Features:
Bug Fixes: