Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 28, 2025

Link issues

fixes #6500

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Switch Badge component styling to use Bootstrap’s text-bg-{color} utility classes for background colors

New Features:

  • Use text-bg-{color} utility classes for badge backgrounds

Bug Fixes:

@bb-auto bb-auto bot added the enhancement New feature or request label Jul 28, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 28, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 28, 2025

Reviewer's Guide

This pull request updates the Badge component to use the Bootstrap 5 “text-bg-*” background utility classes by adjusting both the style definitions and the Razor component’s CSS builder logic.

Class diagram for updated Badge component CSS class logic

classDiagram
    class Badge {
        - string? ClassString
    }
    class CssBuilder {
        +Default(string)
        +AddClass(string, bool)
        +AddClassFromAttributes(object)
        +Build()
    }
    Badge --> CssBuilder : uses
    %% Highlight the change in ClassString logic
    %% Old: .AddClass($"bg-{Color.ToDescriptionString()}", Color != Color.None)
    %% New: .AddClass($"text-bg-{Color.ToDescriptionString()}", Color != Color.None)
Loading

File-Level Changes

Change Details Files
Switch badge background classes from “bg-” to “text-bg-
  • Update SCSS selectors to use .text-bg-secondary and .text-bg-light
  • Modify CssBuilder in Badge.razor.cs to prepend “text-bg-” instead of “bg-”
src/BootstrapBlazor/Components/Badge/Badge.razor.scss
src/BootstrapBlazor/Components/Badge/Badge.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6500 Update the Badge component to use the 'text-bg-color' class instead of the 'bg-color' class.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang closed this Jul 28, 2025
@ArgoZhang ArgoZhang deleted the refactor-badge branch July 28, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(AutoGenerateColumn): update final value logic documentation

2 participants