feat(Message): Add ”DismissMode“ in MessageOption #6508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks for your PR, @momijijin. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's GuideThis PR introduces a new MessageDismissMode enum and integrates it into MessageOption to control how messages are dismissed (hidden or deleted), and updates both the JS and server-side logic to enforce the DeleteSource behavior. Sequence diagram for message dismissal with new DismissModesequenceDiagram
participant User
participant JS as Message.razor.js
participant Server as Message.razor.cs
participant MessageOption
User->>JS: Dismiss message (e.g., click close)
JS->>JS: Remove message from items
alt Last message dismissed
JS->>Server: invokeMethodAsync(callback)
else More messages remain
JS->>Server: invokeMethodAsync('Dismiss', alertId)
Server->>MessageOption: Check DismissMode
alt DismissMode == DeleteSource
Server->>Server: Remove message from _messages
else DismissMode == OnlyHidden
Server->>Server: Only hide message
end
end
Class diagram for MessageOption and MessageDismissMode changesclassDiagram
class MessageOption {
MessageShowMode ShowMode
MessageDismissMode DismissMode
}
class MessageShowMode {
<<enum>>
Single
Multiple
}
class MessageDismissMode {
<<enum>>
OnlyHidden
DeleteSource
}
MessageOption --> MessageShowMode
MessageOption --> MessageDismissMode
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @momijijin - I've reviewed your changes - here's some feedback:
- The new DismissMode isn’t referenced in the JS logic – you need to pass the mode into Message.razor.js and only call the ‘Dismiss’ callback when DismissMode is DeleteSource.
- When popping the last message you invoke msg.callback without an id, but your C# Dismiss method expects an id parameter – ensure the callbacks and signatures line up.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new DismissMode isn’t referenced in the JS logic – you need to pass the mode into Message.razor.js and only call the ‘Dismiss’ callback when DismissMode is DeleteSource.
- When popping the last message you invoke msg.callback without an id, but your C# Dismiss method expects an id parameter – ensure the callbacks and signatures line up.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6508 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31387 31390 +3
Branches 4430 4431 +1
=========================================
+ Hits 31387 31390 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6506
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce configurable dismiss behavior for message component by adding a new DismissMode option and supporting client-server handling for per-message dismissal.
New Features:
Enhancements: