-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(ImageViewer): support dynamic update Url parameter #6510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR enables dynamic updates of the ImageViewer's URL parameter by always providing a previewer ID and refreshing the internal image element reference when the preview list changes. Class diagram for updated ImageViewer componentclassDiagram
class ImageViewer {
- PreviewList : List
- Id : string
- PreviewerId : string
+ RenderChildContent() : RenderFragment
+ ShowPreviewList : bool
}
ImageViewer : PreviewerId always returns $"prev_{Id}"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6510 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31387 31387
Branches 4431 4430 -1
=========================================
Hits 31387 31387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6509
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable dynamic URL updates in ImageViewer by guaranteeing a previewer ID on render and reacquiring the img element in the JavaScript update method
New Features:
Bug Fixes:
Enhancements: