-
-
Notifications
You must be signed in to change notification settings - Fork 362
doc(TaskService): disable task service on dev mode #6529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideBackground task services (AddTaskServices, ClearTempFilesService, MockOnlineContributor) are now conditionally registered only in non-DEBUG builds, disabling them in development mode. Class diagram for ServiceCollectionExtensions changesclassDiagram
class ServiceCollectionExtensions {
+AddBootstrapBlazorServerService(IServiceCollection services)
}
class ClearTempFilesService
class MockOnlineContributor
class MockReceiveSocketServerService
class MockSendReceiveSocketServerService
class MockCustomProtocolSocketServerService
class TaskServices
ServiceCollectionExtensions --> "registers (non-DEBUG only)" ClearTempFilesService
ServiceCollectionExtensions --> "registers (non-DEBUG only)" MockOnlineContributor
ServiceCollectionExtensions --> "registers (non-DEBUG only)" TaskServices
ServiceCollectionExtensions --> "registers (always)" MockReceiveSocketServerService
ServiceCollectionExtensions --> "registers (always)" MockSendReceiveSocketServerService
ServiceCollectionExtensions --> "registers (always)" MockCustomProtocolSocketServerService
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Consider using a runtime check (e.g. IHostEnvironment.IsDevelopment()) instead of #if DEBUG so you can toggle task services without rebuilding the app.
- Add a brief comment explaining why certain hosted services remain enabled in dev mode to improve future maintainability and avoid confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using a runtime check (e.g. IHostEnvironment.IsDevelopment()) instead of #if DEBUG so you can toggle task services without rebuilding the app.
- Add a brief comment explaining why certain hosted services remain enabled in dev mode to improve future maintainability and avoid confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6529 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31387 31387
Branches 4431 4430 -1
=========================================
Hits 31387 31387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6528
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: