-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Bootstrap): bump bootstrap 5.3.7 #6534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR upgrades Bootstrap from v5.3.6 to v5.3.7 by updating version identifiers in JS and CSS, removes an obsolete ESLint suppression, and adds logic to toggle the click-trigger active state for correct toggle behavior. Sequence diagram for updated click trigger toggle logicsequenceDiagram
participant User as actor User
participant Element
participant Tooltip as Tooltip/Popover
User->>Element: click
Element->>Tooltip: EventHandler.onClick(event)
Tooltip->>Tooltip: _initializeOnDelegatedTarget(event)
Tooltip->>Tooltip: _activeTrigger[TRIGGER_CLICK] = !(context._isShown() && context._activeTrigger[TRIGGER_CLICK])
Tooltip->>Tooltip: toggle()
Class diagram for updated click trigger logic in Bootstrap Tooltip/PopoverclassDiagram
class TooltipOrPopover {
_element
_config
_activeTrigger
_isShown()
toggle()
_initializeOnDelegatedTarget(event)
}
EventHandler <|-- TooltipOrPopover
TooltipOrPopover : onClick(event)
TooltipOrPopover : _activeTrigger[TRIGGER_CLICK] = !(context._isShown() && context._activeTrigger[TRIGGER_CLICK])
TooltipOrPopover : toggle()
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- It looks like you updated the
VERSIONconstant at the top but thestatic get VERSION()getter farther down still returns the old version—please make sure every version reference is bumped to 5.3.7. - The added line toggling
context._activeTrigger[TRIGGER_CLICK]appears to be a non-upstream customization—please document why it’s needed or isolate it so future upgrades are easier. - Since this is a full copy of the Bootstrap bundle, consider managing Bootstrap as a dependency (e.g. via npm) or automating the version bump to reduce manual diffs going forward.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- It looks like you updated the `VERSION` constant at the top but the `static get VERSION()` getter farther down still returns the old version—please make sure every version reference is bumped to 5.3.7.
- The added line toggling `context._activeTrigger[TRIGGER_CLICK]` appears to be a non-upstream customization—please document why it’s needed or isolate it so future upgrades are easier.
- Since this is a full copy of the Bootstrap bundle, consider managing Bootstrap as a dependency (e.g. via npm) or automating the version bump to reduce manual diffs going forward.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6534 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31387 31392 +5
Branches 4430 4431 +1
=========================================
+ Hits 31387 31392 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6533
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Upgrade embedded Bootstrap assets to v5.3.7
Bug Fixes:
Enhancements: