Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 3, 2025

Link issues

fixes #6533

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Upgrade embedded Bootstrap assets to v5.3.7

Bug Fixes:

  • Incorporate upstream bug fix for toggling click trigger state in dropdowns

Enhancements:

  • Bump Bootstrap version constant and update JS bundle
  • Update CSS headers to Bootstrap 5.3.7

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 3, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 3, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 3, 2025

Reviewer's Guide

This PR upgrades Bootstrap from v5.3.6 to v5.3.7 by updating version identifiers in JS and CSS, removes an obsolete ESLint suppression, and adds logic to toggle the click-trigger active state for correct toggle behavior.

Sequence diagram for updated click trigger toggle logic

sequenceDiagram
    participant User as actor User
    participant Element
    participant Tooltip as Tooltip/Popover
    User->>Element: click
    Element->>Tooltip: EventHandler.onClick(event)
    Tooltip->>Tooltip: _initializeOnDelegatedTarget(event)
    Tooltip->>Tooltip: _activeTrigger[TRIGGER_CLICK] = !(context._isShown() && context._activeTrigger[TRIGGER_CLICK])
    Tooltip->>Tooltip: toggle()
Loading

Class diagram for updated click trigger logic in Bootstrap Tooltip/Popover

classDiagram
    class TooltipOrPopover {
        _element
        _config
        _activeTrigger
        _isShown()
        toggle()
        _initializeOnDelegatedTarget(event)
    }
    EventHandler <|-- TooltipOrPopover
    TooltipOrPopover : onClick(event)
    TooltipOrPopover : _activeTrigger[TRIGGER_CLICK] = !(context._isShown() && context._activeTrigger[TRIGGER_CLICK])
    TooltipOrPopover : toggle()
Loading

File-Level Changes

Change Details Files
Bump Bootstrap version to 5.3.7
  • Update version banner comments in JS and CSS headers
  • Update VERSION constant in bootstrap.bundle.js
src/BootstrapBlazor/wwwroot/core/bootstrap/js/bootstrap.bundle.js
src/BootstrapBlazor/wwwroot/core/bootstrap/js/bootstrap.bundle.min.js
src/BootstrapBlazor/wwwroot/core/bootstrap/css/bootstrap.css
src/BootstrapBlazor/wwwroot/core/bootstrap/css/bootstrap.rtl.css
src/BootstrapBlazor/wwwroot/core/bootstrap/css/bootstrap.min.css
Remove unnecessary ESLint suppression
  • Delete "eslint-disable-next-line unicorn/better-regex" comment
src/BootstrapBlazor/wwwroot/core/bootstrap/js/bootstrap.bundle.js
Fix click-trigger active state toggling
  • Add update to context._activeTrigger[TRIGGER_CLICK] before calling toggle()
src/BootstrapBlazor/wwwroot/core/bootstrap/js/bootstrap.bundle.js

Assessment against linked issues

Issue Objective Addressed Explanation
#6533 Update Bootstrap dependency to version 5.3.7 in the codebase (JavaScript and CSS files).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit e12f5cd into main Aug 3, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the chore-bs branch August 3, 2025 01:46
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • It looks like you updated the VERSION constant at the top but the static get VERSION() getter farther down still returns the old version—please make sure every version reference is bumped to 5.3.7.
  • The added line toggling context._activeTrigger[TRIGGER_CLICK] appears to be a non-upstream customization—please document why it’s needed or isolate it so future upgrades are easier.
  • Since this is a full copy of the Bootstrap bundle, consider managing Bootstrap as a dependency (e.g. via npm) or automating the version bump to reduce manual diffs going forward.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- It looks like you updated the `VERSION` constant at the top but the `static get VERSION()` getter farther down still returns the old version—please make sure every version reference is bumped to 5.3.7.
- The added line toggling `context._activeTrigger[TRIGGER_CLICK]` appears to be a non-upstream customization—please document why it’s needed or isolate it so future upgrades are easier.
- Since this is a full copy of the Bootstrap bundle, consider managing Bootstrap as a dependency (e.g. via npm) or automating the version bump to reduce manual diffs going forward.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a379095) to head (7044f6b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6534   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          714       714           
  Lines        31387     31392    +5     
  Branches      4430      4431    +1     
=========================================
+ Hits         31387     31392    +5     
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Bootstrap): bump bootstrap 5.3.7

2 participants