Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 3, 2025

Link issues

fixes #6537

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Apply outline style to CheckboxList items by using btn-outline-{color} classes and adjust CSS variables for disabled and info outline variants; update sample to demonstrate label and display text

New Features:

  • Enable outline style for CheckboxList buttons by using btn-outline-{color} classes instead of solid fills

Enhancements:

  • Remove default solid border from the button group and configure CSS variables for hover/active colors in disabled and info outline states
  • Update sample usage of CheckboxList to include ShowLabel and DisplayText parameters

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 3, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 3, 2025

Reviewer's Guide

Introduce an outline variant for CheckboxList buttons by updating SCSS styles, refactoring CSS class generation, adjusting component markup, and enhancing the sample to demonstrate the new style.

File-Level Changes

Change Details Files
Apply outline button style in SCSS
  • Removed default solid border from .btn-group
  • Added CSS variable overrides for disabled state
  • Defined .btn-outline-info active text color
src/BootstrapBlazor/Components/Checkbox/CheckboxList.razor.scss
Refactor button class builder to include outline variant
  • Always add 'btn-outline-{color}' class
  • Separate 'active' class assignment
src/BootstrapBlazor/Components/Checkbox/CheckboxList.razor.cs
Adjust Razor markup formatting
  • Split DynamicElement attributes onto separate lines for readability
src/BootstrapBlazor/Components/Checkbox/CheckboxList.razor
Update sample usage to showcase new style
  • Enabled ShowLabel property
  • Added DisplayText="Hobby"
src/BootstrapBlazor.Server/Components/Samples/CheckboxLists.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6537 Add an outline style to the CheckboxList component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 3, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • There’s a stray BOM/non-printable character at the top of CheckboxList.razor.scss—remove it to avoid encoding/build issues.
  • Currently the SCSS only defines .btn-outline-info; consider generating the outline style for all btn-outline-{color} variants (e.g. via Bootstrap mixins) instead of hard-coding info.
  • The sample update adds ShowLabel/DisplayText props but this PR doesn’t include their implementation in CheckboxList—either implement support for those props or remove them from the sample.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a stray BOM/non-printable character at the top of CheckboxList.razor.scss—remove it to avoid encoding/build issues.
- Currently the SCSS only defines `.btn-outline-info`; consider generating the outline style for all `btn-outline-{color}` variants (e.g. via Bootstrap mixins) instead of hard-coding info.
- The sample update adds ShowLabel/DisplayText props but this PR doesn’t include their implementation in CheckboxList—either implement support for those props or remove them from the sample.

## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Components/Checkbox/CheckboxList.razor.scss:66` </location>
<code_context>
             }
         }
+
+        .btn-outline-info {
+            --bs-btn-active-color: #fff;
+        }
     }
</code_context>

<issue_to_address>
Hardcoding active color for .btn-outline-info may reduce theme flexibility.

Consider parameterizing --bs-btn-active-color or using a more generic approach to maintain compatibility with different themes and future color variants.

Suggested implementation:

```
        .btn-outline-info {
            --bs-btn-active-color: var(--bs-btn-info-active-color, #fff);
        }

```

To fully support this, you should define `--bs-btn-info-active-color` in your global theme or root CSS, so it can be easily customized for different themes. For example, in your root CSS or theme file:

:root {
  --bs-btn-info-active-color: #fff; // or your preferred default
}

This allows you to change the active color for `.btn-outline-info` in one place, maintaining theme flexibility.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit b008908 into main Aug 3, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-checkbox-list branch August 3, 2025 02:25
@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (184b491) to head (efdde83).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6538   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          714       714           
  Lines        31395     31396    +1     
  Branches      4432      4432           
=========================================
+ Hits         31395     31396    +1     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(CheckboxList): add outline style

2 participants