Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 3, 2025

Link issues

fixes #6539

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Switch RadioList component to use outline button styles, removing solid backgrounds and default borders while ensuring proper styling for active, disabled, and info variants.

New Features:

  • Introduce outline button variant for RadioList items using btn-outline-{color} classes.

Enhancements:

  • Remove default border from btn-group variant in RadioList.
  • Adjust CSS variables for disabled hover/active colors and set active color on info outline buttons.
  • Refactor GetButtonItemClassString to always apply btn-outline-{color} and separate active state class.

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 3, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 3, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 3, 2025

Reviewer's Guide

Introduces an outline variant for the RadioList component by overhauling SCSS styles and updating the class-building logic to apply btn-outline-{Color} and manage active/disabled states independently.

File-Level Changes

Change Details Files
Refactor SCSS for outline variant and state styles
  • Removed default .btn-group border
  • Added CSS var overrides for disabled hover and active states
  • Defined .btn-outline-info active color override
src/BootstrapBlazor/Components/Radio/RadioList.razor.scss
Update button class builder to use outline classes
  • Replaced combined active bg-{Color} class with btn-outline-{Color}
  • Added separate active class when an item is selected
src/BootstrapBlazor/Components/Radio/RadioList.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6539 Add an outline style to the RadioList component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Aug 3, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Components/Radio/RadioList.razor.scss:50` </location>
<code_context>
             }
         }
+
+        .btn-outline-info {
+            --bs-btn-active-color: var(--bb-radio-group-item-active-color);
+        }
     }
</code_context>

<issue_to_address>
The new .btn-outline-info selector may not cover all color variants.

If you plan to use other variants like 'primary' or 'secondary', consider adding similar rules for them to maintain consistency.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
        .btn-outline-info {
            --bs-btn-active-color: var(--bb-radio-group-item-active-color);
        }
=======
        .btn-outline-info {
            --bs-btn-active-color: var(--bb-radio-group-item-active-color);
        }
        .btn-outline-primary {
            --bs-btn-active-color: var(--bb-radio-group-item-active-color);
        }
        .btn-outline-secondary {
            --bs-btn-active-color: var(--bb-radio-group-item-active-color);
        }
>>>>>>> REPLACE

</suggested_fix>

### Comment 2
<location> `src/BootstrapBlazor/Components/Radio/RadioList.razor.cs:49` </location>
<code_context>
         .Build();

     private string? GetButtonItemClassString(SelectedItem item) => CssBuilder.Default("btn")
-        .AddClass($"active bg-{Color.ToDescriptionString()}", CurrentValueAsString == item.Value)
+        .AddClass($"btn-outline-{Color.ToDescriptionString()}")
+        .AddClass("active", CurrentValueAsString == item.Value)
</code_context>

<issue_to_address>
The removal of the bg-{Color} class may affect background coloring for active buttons.

If you still want a background color for active buttons, consider adding the appropriate styling, as only the 'active' class is now applied.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.Build();

private string? GetButtonItemClassString(SelectedItem item) => CssBuilder.Default("btn")
.AddClass($"active bg-{Color.ToDescriptionString()}", CurrentValueAsString == item.Value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: The removal of the bg-{Color} class may affect background coloring for active buttons.

If you still want a background color for active buttons, consider adding the appropriate styling, as only the 'active' class is now applied.

@ArgoZhang ArgoZhang merged commit 09e200c into main Aug 3, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the feat-radio-button branch August 3, 2025 02:29
@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b008908) to head (97a7adc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6540   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          714       714           
  Lines        31396     31397    +1     
  Branches      4432      4432           
=========================================
+ Hits         31396     31397    +1     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(RadioList): add outline style

2 participants