-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(RadioList): add outline style #6540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIntroduces an outline variant for the RadioList component by overhauling SCSS styles and updating the class-building logic to apply File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Radio/RadioList.razor.scss:50` </location>
<code_context>
}
}
+
+ .btn-outline-info {
+ --bs-btn-active-color: var(--bb-radio-group-item-active-color);
+ }
}
</code_context>
<issue_to_address>
The new .btn-outline-info selector may not cover all color variants.
If you plan to use other variants like 'primary' or 'secondary', consider adding similar rules for them to maintain consistency.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
.btn-outline-info {
--bs-btn-active-color: var(--bb-radio-group-item-active-color);
}
=======
.btn-outline-info {
--bs-btn-active-color: var(--bb-radio-group-item-active-color);
}
.btn-outline-primary {
--bs-btn-active-color: var(--bb-radio-group-item-active-color);
}
.btn-outline-secondary {
--bs-btn-active-color: var(--bb-radio-group-item-active-color);
}
>>>>>>> REPLACE
</suggested_fix>
### Comment 2
<location> `src/BootstrapBlazor/Components/Radio/RadioList.razor.cs:49` </location>
<code_context>
.Build();
private string? GetButtonItemClassString(SelectedItem item) => CssBuilder.Default("btn")
- .AddClass($"active bg-{Color.ToDescriptionString()}", CurrentValueAsString == item.Value)
+ .AddClass($"btn-outline-{Color.ToDescriptionString()}")
+ .AddClass("active", CurrentValueAsString == item.Value)
</code_context>
<issue_to_address>
The removal of the bg-{Color} class may affect background coloring for active buttons.
If you still want a background color for active buttons, consider adding the appropriate styling, as only the 'active' class is now applied.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| .Build(); | ||
|
|
||
| private string? GetButtonItemClassString(SelectedItem item) => CssBuilder.Default("btn") | ||
| .AddClass($"active bg-{Color.ToDescriptionString()}", CurrentValueAsString == item.Value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: The removal of the bg-{Color} class may affect background coloring for active buttons.
If you still want a background color for active buttons, consider adding the appropriate styling, as only the 'active' class is now applied.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6540 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31396 31397 +1
Branches 4432 4432
=========================================
+ Hits 31396 31397 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6539
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Switch RadioList component to use outline button styles, removing solid backgrounds and default borders while ensuring proper styling for active, disabled, and info variants.
New Features:
Enhancements: