-
-
Notifications
You must be signed in to change notification settings - Fork 362
Add interface IWebClientService
#6541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your PR, @kimdiego2098. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's GuideExtracted an interface for WebClientService and refactored registrations and consumers to use the abstraction, with the concrete class updated to implement the new interface. Class diagram for IWebClientService extraction and usageclassDiagram
class IWebClientService {
<<interface>>
+Task<ClientInfo> GetClientInfo()
+void SetData(ClientInfo client)
}
class WebClientService {
+Task<ClientInfo> GetClientInfo()
+void SetData(ClientInfo client)
+Dispose()
}
IWebClientService <|.. WebClientService
class ClientInfo
%% Other classes (Online, Client, Dispatches, Locators) now depend on IWebClientService instead of WebClientService
class Online {
-IWebClientService? WebClientService
}
class Client {
-IWebClientService? ClientService
}
class Dispatches {
-IWebClientService? ClientService
}
class Locators {
-IWebClientService? ClientService
}
Online --> IWebClientService
Client --> IWebClientService
Dispatches --> IWebClientService
Locators --> IWebClientService
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kimdiego2098 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6541 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31395 31397 +2
Branches 4432 4432
=========================================
+ Hits 31395 31397 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by Sourcery
Introduce IWebClientService interface and refactor WebClientService to depend on it, update DI registration and replace concrete service injections with the new interface across components, samples, and tests
Enhancements:
Tests: