feat(Toolbar): add Toolbar component #6547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/UnitTest/Components/ButtonTest.cs
Reviewer's GuideImplements a new Toolbar UI component (with subcomponents, styling and samples), enhances CheckboxList/RadioList to support custom item templates and optional border coloring with updated styles for seamless button groups, and adds a test assertion to validate two-way binding. Class diagram for enhanced CheckboxList and RadioList componentsclassDiagram
class CheckboxList {
+bool IsButton
+bool ShowButtonBorderColor
+string? CheckboxItemClass
+bool ShowBorder
-string? GetButtonItemClassString(SelectedItem item)
}
class RadioList {
+bool ShowButtonBorderColor
-string? GetButtonItemClassString(SelectedItem item)
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/Toolbars.razor.cs:13` </location>
<code_context>
+/// </summary>
+public partial class Toolbars
+{
+ private readonly List<SelectedItem> _items1 = [];
+ private string _item1 = "1,2";
+
</code_context>
<issue_to_address>
Consider extracting repeated item list creation into a helper method and replacing switch expressions with dictionaries to centralize data and icon mappings.
```csharp
// 1. Extract the repeated item list into a helper
private static List<SelectedItem> CreateDefaultItems() => new()
{
new("1", "Text1"),
new("2", "Text2"),
new("3", "Text3")
};
private readonly List<SelectedItem> _items1 = CreateDefaultItems();
private readonly List<SelectedItem> _items2 = CreateDefaultItems();
private readonly List<SelectedItem> _items3 = CreateDefaultItems();
// 2. Replace switch‐expressions with dictionaries
private static readonly Dictionary<string, string> _alignIcons = new()
{
["1"] = "fa-solid fa-align-left",
["2"] = "fa-solid fa-align-center",
["3"] = "fa-solid fa-align-right"
};
private static readonly Dictionary<string, string> _formatIcons = new()
{
["1"] = "fa-solid fa-bold",
["2"] = "fa-solid fa-italic",
["3"] = "fa-solid fa-font"
};
private static string GetIconByItem(string v) => _alignIcons[v];
private static string GetRadioIconByItem(string v) => _formatIcons[v];
```
- OnInitialized can now be removed since lists are built at declaration.
- This keeps behavior identical while centralizing both the data and icon mappings.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6547 +/- ##
===========================================
+ Coverage 99.93% 100.00% +0.06%
===========================================
Files 715 721 +6
Lines 31471 31519 +48
Branches 4444 4449 +5
===========================================
+ Hits 31451 31519 +68
+ Misses 15 0 -15
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6546
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Implement a new Toolbar component suite and enhance button lists by adding item templates, border color control, and refined styling
New Features:
Enhancements:
Documentation:
Tests: