doc(Home): add responsive support for logo image #6549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideRefactored home page masthead and component styles to improve responsiveness: simplified masthead link and logo display, streamlined docs button, moved header padding to media queries, and added mobile-specific OTP input sizing. Class diagram for OtpInputs.razor responsive style changesclassDiagram
class OtpInputsRazor {
+.otp-input-demo
+.bb-otp-input
+@media(max-width: 768px)
}
OtpInputsRazor : - Mobile-specific input sizing
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- The
@@mediarule in OtpInputs.razor looks like a typo—change it to@mediaso the responsive styles actually apply. - It looks like the braces in your Index.razor.css media query got misaligned—make sure all the intended rules stay inside the
@media (min-width: 768px)block. - The OTP input style changes aren’t really related to adding responsive support for the logo—consider moving that into its own PR for clearer separation of concerns.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `@@media` rule in OtpInputs.razor looks like a typo—change it to `@media` so the responsive styles actually apply.
- It looks like the braces in your Index.razor.css media query got misaligned—make sure all the intended rules stay inside the `@media (min-width: 768px)` block.
- The OTP input style changes aren’t really related to adding responsive support for the logo—consider moving that into its own PR for clearer separation of concerns.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/OtpInputs.razor:14` </location>
<code_context>
text-align: center;
}
+ @@media(max-width: 768px) {
.otp-input-demo .bb-otp-input {
--bb-otp-item-width: 32px;
</code_context>
<issue_to_address>
There is a typo in the CSS: double '@' in '@@media'.
Replace '@@media(max-width: 768px)' with '@media(max-width: 768px)' to ensure the CSS is applied correctly.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
@@media(max-width: 768px) {
.otp-input-demo .bb-otp-input {
--bb-otp-item-width: 32px;
--bb-otp-font-size: 1.2em;
}
}
=======
@media(max-width: 768px) {
.otp-input-demo .bb-otp-input {
--bb-otp-item-width: 32px;
--bb-otp-font-size: 1.2em;
}
}
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+14
to
+19
| @@media(max-width: 768px) { | ||
| .otp-input-demo .bb-otp-input { | ||
| --bb-otp-item-width: 32px; | ||
| --bb-otp-font-size: 1.2em; | ||
| } | ||
| } |
There was a problem hiding this comment.
issue (typo): There is a typo in the CSS: double '@' in '@@media'.
Replace '@@media(max-width: 768px)' with '@media(max-width: 768px)' to ensure the CSS is applied correctly.
Suggested change
| @@media(max-width: 768px) { | |
| .otp-input-demo .bb-otp-input { | |
| --bb-otp-item-width: 32px; | |
| --bb-otp-font-size: 1.2em; | |
| } | |
| } | |
| @media(max-width: 768px) { | |
| .otp-input-demo .bb-otp-input { | |
| --bb-otp-item-width: 32px; | |
| --bb-otp-font-size: 1.2em; | |
| } | |
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6549 +/- ##
=======================================
Coverage ? 99.93%
=======================================
Files ? 715
Lines ? 31467
Branches ? 4443
=======================================
Hits ? 31447
Misses ? 15
Partials ? 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6548
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve responsiveness of the home page masthead and logo image, streamline layout markup, and enhance the OTPInputs sample for mobile displays
Enhancements: