Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 5, 2025

Link issues

fixes #6552

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Feature-detect navigator.connection in the network monitor module to prevent runtime errors in Safari and other unsupported browsers

Bug Fixes:

  • Only attach and invoke navigator.connection handlers when the API is available
  • Log a warning instead of failing when navigator.connection is not supported

@bb-auto bb-auto bot added the bug Something isn't working label Aug 5, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 5, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 5, 2025

Reviewer's Guide

The PR enhances the network monitoring initialization to handle browsers without the NavigatorConnection API (e.g., Safari) by guarding event binding and initial state updates, and emits a console warning when unsupported.

Class diagram for updated network monitoring module

classDiagram
    class NetModule {
        +init(options)
    }
    NetModule : - updateState(connection)
    NetModule : - onlineStateChanged()
    NetModule : - offlineStateChanged()
    NetModule : +init(options)
    NetModule : +console.warn()
    note for NetModule "init now checks for navigator.connection before binding onchange and calling updateState. If not supported, logs a warning."
Loading

File-Level Changes

Change Details Files
Guard network connection event handling behind navigator.connection check
  • Remove the original unconditional navigator.connection.onchange assignment
  • Wrap the onchange handler registration in an if (navigator.connection) block
  • Move the initial updateState call inside the navigator.connection existence check
  • Add a console.warn for unsupported browsers lacking navigator.connection
src/BootstrapBlazor/wwwroot/modules/net.js

Assessment against linked issues

Issue Objective Addressed Explanation
#6552 Fix the exception thrown in Safari browser by INetworkMonitorService.
#6552 Add support for Safari browser in INetworkMonitorService.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 096d3a7 into main Aug 5, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the fix-connection branch August 5, 2025 02:39
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (582eebd) to head (1c5ee63).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6553   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         715      715           
  Lines       31471    31471           
  Branches     4444     4444           
=======================================
  Hits        31451    31451           
  Misses         15       15           
  Partials        5        5           
Flag Coverage Δ
BB 99.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(INetworkMonitorService): throw exception in safari browser

2 participants