-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(INetworkMonitorService): support safari browser #6553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThe PR enhances the network monitoring initialization to handle browsers without the NavigatorConnection API (e.g., Safari) by guarding event binding and initial state updates, and emits a console warning when unsupported. Class diagram for updated network monitoring moduleclassDiagram
class NetModule {
+init(options)
}
NetModule : - updateState(connection)
NetModule : - onlineStateChanged()
NetModule : - offlineStateChanged()
NetModule : +init(options)
NetModule : +console.warn()
note for NetModule "init now checks for navigator.connection before binding onchange and calling updateState. If not supported, logs a warning."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6553 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 715 715
Lines 31471 31471
Branches 4444 4444
=======================================
Hits 31451 31451
Misses 15 15
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6552
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Feature-detect navigator.connection in the network monitor module to prevent runtime errors in Safari and other unsupported browsers
Bug Fixes: