-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(Card): missing style html attribute #6559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR fixes the missing style HTML attribute propagation by overriding the render logic in BootstrapInputGroupLabel to emit class, style, required flag and arbitrary attributes, and by extending the Card header style builder to include AdditionalAttributes. Class diagram for updated BootstrapInputGroupLabel and Card componentsclassDiagram
class BootstrapInputGroupLabel {
+string? ClassString
+bool IsInputGroupLabel
+void OnParametersSet()
+void BuildRenderTree(RenderTreeBuilder builder)
}
BootstrapInputGroupLabel --|> DisplayBase
class Card {
+string? HeaderStyleString
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This reverts commit c81d0a9.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 721 721
Lines 31519 31520 +1
Branches 4449 4449
=========================================
+ Hits 31519 31520 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6558
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for rendering html 'style' attributes on Card headers and InputGroupLabel components, and refactor InputGroupLabel to a sealed DisplayBase-derived component with a custom render tree implementation.
Bug Fixes:
Enhancements: