-
-
Notifications
You must be signed in to change notification settings - Fork 362
refactor(Toolbar): remove cascade value #6575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refactors the Toolbar components by removing the cascading value mechanism and related component registration and disposal logic to simplify the API and implementation. Class diagram for refactored Toolbar and ToolbarButtonGroupclassDiagram
class Toolbar {
<<partial>>
// Removed: List<ComponentBase> _components
// Removed: void Add(ComponentBase component)
// Removed: void Remove(ComponentBase component)
}
class ToolbarButtonGroup {
<<partial>>
// Removed: Toolbar? Toolbar (CascadingParameter)
// Removed: OnInitialized()
// Removed: DisposeAsync(bool disposing)
// Removed: ValueTask DisposeAsync()
}
ToolbarButtonGroup --|> Toolbar : (previously via CascadingParameter)
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6575 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 721 721
Lines 31578 31559 -19
Branches 4453 4450 -3
=========================================
- Hits 31578 31559 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6574
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove cascade value usage from Toolbar and ToolbarButtonGroup, simplifying child content rendering and eliminating explicit registration logic.
Bug Fixes:
Enhancements: