-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(Table): update style for ScrollingDialogContent #6577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR refactors the EditorForm component by removing the dynamic ClassString, introducing explicit class attributes, restructuring the markup for group and unset-group rendering inside a new form-body wrapper, and removes the now-unused ClassString property. It also tightens the Table component’s scrolling dialog content by adding a max-height constraint to the textarea container. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Confirm that EditorForm's AdditionalAttributes and previous form-body class are still applied as intended after removing the dynamic ClassString builder.
- Split the unrelated EditorForm changes from the Table style update into separate PRs for clearer reviews.
- Abstract or document the magic '133px' value in the max-height calc to improve maintainability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Confirm that EditorForm's AdditionalAttributes and previous form-body class are still applied as intended after removing the dynamic ClassString builder.
- Split the unrelated EditorForm changes from the Table style update into separate PRs for clearer reviews.
- Abstract or document the magic '133px' value in the max-height calc to improve maintainability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6577 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 721 721
Lines 31559 31556 -3
Branches 4450 4450
=========================================
- Hits 31559 31556 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6576
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactor the EditorForm component to simplify CSS class handling and wrap form items in a dedicated container, and fix textarea overflow by adding a max-height rule for scrolling dialog content in the Table component
Bug Fixes:
Enhancements: