Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 9, 2025

Link issues

fixes #6576

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Refactor the EditorForm component to simplify CSS class handling and wrap form items in a dedicated container, and fix textarea overflow by adding a max-height rule for scrolling dialog content in the Table component

Bug Fixes:

  • Add max-height constraint to textarea in scrolling dialogs to prevent overflow

Enhancements:

  • Refactor EditorForm to use a static root class, apply AdditionalAttributes on the root element, and wrap field groups inside a .form-body container

@bb-auto bb-auto bot added the bug Something isn't working label Aug 9, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 9, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 9, 2025

Reviewer's Guide

This PR refactors the EditorForm component by removing the dynamic ClassString, introducing explicit class attributes, restructuring the markup for group and unset-group rendering inside a new form-body wrapper, and removes the now-unused ClassString property. It also tightens the Table component’s scrolling dialog content by adding a max-height constraint to the textarea container.

File-Level Changes

Change Details Files
Refactor EditorForm component structure and styling
  • Replaced dynamic ClassString with @attributes and explicit class "bb-editor"
  • Wrapped field groups in a
    container
  • Removed obsolete ClassString property from code-behind
  • Reorganized conditional logic for ShowUnsetGroupItemsOnTop, GroupItems, and UnsetGroupItems rendering
Components/EditorForm/EditorForm.razor
Components/EditorForm/EditorForm.razor.cs
Add max-height constraint to scrolling dialog content
  • Introduced max-height: calc(100vh - 133px) on textarea scroll container
Components/Table/Table.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#6576 Fix the UI bug caused by the current ScrollingDialogContent styles in the Table component.
#6576 Unify the appearance of the built-in editor dialog and the custom editor dialog styles for a more visually consistent look.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Confirm that EditorForm's AdditionalAttributes and previous form-body class are still applied as intended after removing the dynamic ClassString builder.
  • Split the unrelated EditorForm changes from the Table style update into separate PRs for clearer reviews.
  • Abstract or document the magic '133px' value in the max-height calc to improve maintainability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Confirm that EditorForm's AdditionalAttributes and previous form-body class are still applied as intended after removing the dynamic ClassString builder.
- Split the unrelated EditorForm changes from the Table style update into separate PRs for clearer reviews.
- Abstract or document the magic '133px' value in the max-height calc to improve maintainability.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 53b67c3 into main Aug 9, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the fix-editor branch August 9, 2025 05:02
@codecov
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (299e143) to head (6ab905c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6577   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          721       721           
  Lines        31559     31556    -3     
  Branches      4450      4450           
=========================================
- Hits         31559     31556    -3     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Table): 设置 ScrollingDialogContent 样式导致 UI 不正确

2 participants