Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 10, 2025

Link issues

fixes #6580

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enable asynchronous click handling in LinkButton by introducing IsAsync with loading and disable state management, centralize click logic in ButtonBase, and update tests accordingly

New Features:

  • Add IsAsync support to LinkButton to manage asynchronous click handlers with loading and disable states

Enhancements:

  • Move HandlerClick method from Button.razor.cs into ButtonBase to centralize click handling logic

Tests:

  • Update LinkButtonTest to use async OnClick delegate and verify click behavior when IsAsync is enabled

Chores:

  • Remove duplicate HandlerClick implementation and an unused using directive in LinkButton

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 10, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 10, 2025

Reviewer's Guide

This PR introduces asynchronous click support for LinkButton by refactoring the click handler into the base component (ButtonBase), enhancing OnClickButton to manage loading/disabled states when IsAsync is enabled, and updating unit tests to cover async behavior.

Sequence diagram for LinkButton async click handling

sequenceDiagram
    participant User as actor
    participant LinkButton
    participant ButtonBase
    User->>LinkButton: Clicks button
    LinkButton->>LinkButton: If IsAsync, set IsAsyncLoading/IsDisabled
    LinkButton->>ButtonBase: HandlerClick()
    ButtonBase->>ButtonBase: OnClickWithoutRender/OnClick
    LinkButton->>LinkButton: If IsAsync, restore IsDisabled/IsAsyncLoading
Loading

Class diagram for updated ButtonBase and LinkButton async click support

classDiagram
    class ButtonBase {
        +OnClickWithoutRender
        +OnClick
        +IsAsync
        +IsNotRender
        +HandlerClick()
    }
    class LinkButton {
        +IsAsyncLoading
        +IsDisabled
        +IsKeepDisabled
        +OnClickButton()
    }
    ButtonBase <|-- LinkButton
    ButtonBase : +HandlerClick() (moved from Button)
    LinkButton : +OnClickButton() (updated for async)
Loading

File-Level Changes

Change Details Files
Extracted and centralized click handling logic
  • Removed duplicate HandlerClick from Button.razor.cs
  • Added HandlerClick implementation to ButtonBase.cs
src/BootstrapBlazor/Components/Button/Button.razor.cs
src/BootstrapBlazor/Components/Button/ButtonBase.cs
Enabled IsAsync workflow in LinkButton
  • Adjusted OnClickButton to set IsAsyncLoading and IsDisabled when IsAsync
  • Replaced inline invocation with call to HandlerClick
  • Restored IsDisabled and IsAsyncLoading after click
src/BootstrapBlazor/Components/Button/LinkButton.cs
Updated LinkButton unit tests for asynchronous clicks
  • Converted OnClick_Ok to async Task test
  • Added IsAsync flag and async OnClick delegate
  • Awaited link.Click() and assertion
test/UnitTest/Components/LinkButtonTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6580 Add support for the IsAsync function/parameter to LinkButton, enabling asynchronous click handling.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 10, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Aug 10, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Components/Button/LinkButton.cs:122` </location>
<code_context>
     private async Task OnClickButton()
     {
-        if (OnClickWithoutRender != null)
+        if (IsAsync)
         {
-            await OnClickWithoutRender();
+            IsAsyncLoading = true;
+            IsDisabled = true;
         }
</code_context>

<issue_to_address>
Async state management added before click handling.

Check if IsAsyncLoading and IsDisabled remain accurate if HandlerClick throws an exception or completes synchronously.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Aug 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e618bf9) to head (58619f5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6581   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          721       721           
  Lines        31559     31562    +3     
  Branches      4450      4450           
=========================================
+ Hits         31559     31562    +3     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(LinkButton): support IsAsync function

2 participants