-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Dropdown): update Color default value #6592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Dropdown component to use Color.Primary as its default and revises the CSS class builder by removing the fallback logic for Color.None. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Add an entry in the CHANGELOG to document the breaking change of Dropdown’s default color from None to Primary.
- Update any demo pages or examples to reflect the new default Primary color behavior in Dropdown components.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add an entry in the CHANGELOG to document the breaking change of Dropdown’s default color from None to Primary.
- Update any demo pages or examples to reflect the new default Primary color behavior in Dropdown components.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Dropdown/Dropdown.razor.cs:70` </location>
<code_context>
.Build();
/// <summary>
- /// 获得/设置 颜色 默认 Color.None 无设置
+ /// 获得/设置 颜色 默认 Color.Primary 无设置
/// </summary>
[Parameter]
</code_context>
<issue_to_address>
The summary comment update should clarify that Color.Primary is now the default.
The phrase '无设置' may cause confusion, as a default is now always present. Please reword to clarify that Color.Primary is used unless overridden.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
/// <summary>
/// 获得/设置 颜色 默认 Color.Primary 无设置
/// </summary>
=======
/// <summary>
/// 获得/设置 颜色。默认值为 Color.Primary,除非被显式设置为其他值。
/// </summary>
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This was referenced Aug 15, 2025
This was referenced Aug 22, 2025
This was referenced Sep 3, 2025
This was referenced Sep 11, 2025
This was referenced Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6591
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update Dropdown component to use a primary button style by default by changing the default Color value to Primary and adjusting the CSS builder logic
Bug Fixes:
Enhancements: