-
-
Notifications
You must be signed in to change notification settings - Fork 362
doc(Table): add DateTime edit sample code #6603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the table editing sample by replacing the default DateTime column with a custom EditTemplate that embeds a DateTimePicker component for inline editing. Class diagram for TableColumn with custom EditTemplate for DateTimeclassDiagram
TableColumn <|-- DateTimeTableColumn
class TableColumn {
+Field
+Width
+EditTemplate
}
class DateTimeTableColumn {
+EditTemplate: DateTimePicker
}
DateTimeTableColumn : EditTemplate uses DateTimePicker
class DateTimePicker {
+Value
+ViewMode
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31669 31669
Branches 4458 4458
=========================================
Hits 31669 31669
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6584
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add DateTimePicker edit template to the TablesEdit sample to demonstrate inline DateTime editing in table rows
Enhancements:
Documentation: