Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 12, 2025

Link issues

fixes #6584

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add DateTimePicker edit template to the TablesEdit sample to demonstrate inline DateTime editing in table rows

Enhancements:

  • Introduce a DateTimePicker within the TableColumn edit template for the DateTime field in the TablesEdit sample

Documentation:

  • Update TablesEdit.razor sample to include the DateTime edit example using DateTimePicker

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 12, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 12, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the table editing sample by replacing the default DateTime column with a custom EditTemplate that embeds a DateTimePicker component for inline editing.

Class diagram for TableColumn with custom EditTemplate for DateTime

classDiagram
    TableColumn <|-- DateTimeTableColumn
    class TableColumn {
      +Field
      +Width
      +EditTemplate
    }
    class DateTimeTableColumn {
      +EditTemplate: DateTimePicker
    }
    DateTimeTableColumn : EditTemplate uses DateTimePicker
    class DateTimePicker {
      +Value
      +ViewMode
    }
Loading

File-Level Changes

Change Details Files
Introduce a custom edit template for the DateTime column
  • Replaced the standalone TableColumn for DateTime with a templated version
  • Added an EditTemplate block with Context binding
  • Inserted a DateTimePicker component bound to the row’s DateTime property with ViewMode set to DateTime
src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6584 Add a sample in the Table component documentation showing how to edit both date and time fields (not just date) using a DateTime picker.
#6584 Demonstrate a more intuitive layout for date and time editing in the Table component, similar to the example shown in the issue (e.g., using a DateTimePicker in the edit dialog).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 60d1be7 into main Aug 12, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the doc-table branch August 12, 2025 01:15
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2c5f4ca) to head (6083315).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6603   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31669     31669           
  Branches      4458      4458           
=========================================
  Hits         31669     31669           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(DatePicker): 表格编辑中增加调整时间的示例

2 participants