-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Mask): add OnCloseAsync cascade parameter #6609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your PR, @j4587698. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's GuideIntroduces an OnCloseAsync callback into the Mask component, allowing child content to programmatically close the mask via a cascading parameter, and updates sample pages to demonstrate this behavior. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @j4587698 - I've reviewed your changes - here's some feedback:
- Rename the cascading delegate name from
CloseAsyncto something more descriptive likeOnMaskCloseAsyncto avoid generic naming and improve clarity. - Consider adding an
OnCloseAsynccallback property onMaskOptionso consumers can hook into the close event directly instead of relying solely on a CascadingParameter. - Expose the
CloseAsyncmethod (or a similarly named public API) on the Mask component or MaskService to allow programmatic closing without requiring a CascadingParameter.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Rename the cascading delegate name from `CloseAsync` to something more descriptive like `OnMaskCloseAsync` to avoid generic naming and improve clarity.
- Consider adding an `OnCloseAsync` callback property on `MaskOption` so consumers can hook into the close event directly instead of relying solely on a CascadingParameter.
- Expose the `CloseAsync` method (or a similarly named public API) on the Mask component or MaskService to allow programmatic closing without requiring a CascadingParameter.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6609 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31669 31672 +3
Branches 4458 4458
=========================================
+ Hits 31669 31672 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 1716203.
Link issues
fixes #6608
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add asynchronous close callback support to the Mask component and update the samples to demonstrate its usage.
New Features:
Enhancements: