Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 14, 2025

Link issues

fixes #6618

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Handle interface types in ObjectExtensions.CreateInstance to return default instead of throwing and add a unit test for this behavior

New Features:

  • Make CreateInstance return default when TItem is an interface

Tests:

  • Add unit test to verify CreateInstance returns null for interface types

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 14, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 14, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds support for interface-style generic types in ObjectExtensions.CreateInstance by early-returning default for interfaces and introduces a unit test to verify this behavior.

Class diagram for updated ObjectExtensions.CreateInstance method

classDiagram
    class ObjectExtensions {
        +static TItem? CreateInstance<TItem>(bool isAutoInitializeModelProperty = false)
    }
    ObjectExtensions : CreateInstance<TItem>()
    note for ObjectExtensions "Now returns default if TItem is an interface"
Loading

Flow diagram for CreateInstance interface support logic

flowchart TD
    A[Start CreateInstance<TItem>] --> B{Is TItem an interface?}
    B -- Yes --> C[Return default]
    B -- No --> D[Create instance using Activator.CreateInstance<TItem>]
    D --> E{isAutoInitializeModelProperty?}
    E -- Yes --> F[Initialize model properties]
    E -- No --> G[Return instance]
    F --> G[Return instance]
Loading

File-Level Changes

Change Details Files
Handle interface types in CreateInstance
  • Check if TItem is an interface and return default
  • Avoid activating interface via Activator.CreateInstance
src/BootstrapBlazor/Extensions/ObjectExtensions.cs
Add unit test for interface instance creation
  • Add MockInterface definition
  • Assert CreateInstance returns null
test/UnitTest/Extensions/ObjectExtensionsTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6618 Support using interface types (TItem) in the Table component, specifically allowing CreateInstance() to handle interface types without error.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit f5b665b into main Aug 14, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the feat-table branch August 14, 2025 11:39
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Extensions/ObjectExtensions.cs:249` </location>
<code_context>
     /// <returns>An instance of the specified type with initialized properties.</returns>
     public static TItem? CreateInstance<TItem>(bool isAutoInitializeModelProperty = false)
     {
+        if(typeof(TItem).IsInterface)
+        {
+            return default;
+        }
+
</code_context>

<issue_to_address>
Consider handling abstract classes similarly to interfaces.

Abstract classes cannot be instantiated either; consider checking typeof(TItem).IsAbstract to prevent runtime exceptions.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
        if(typeof(TItem).IsInterface)
        {
            return default;
        }
=======
        if(typeof(TItem).IsInterface || typeof(TItem).IsAbstract)
        {
            return default;
        }
>>>>>>> REPLACE

</suggested_fix>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +249 to +252
if(typeof(TItem).IsInterface)
{
return default;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Consider handling abstract classes similarly to interfaces.

Abstract classes cannot be instantiated either; consider checking typeof(TItem).IsAbstract to prevent runtime exceptions.

Suggested change
if(typeof(TItem).IsInterface)
{
return default;
}
if(typeof(TItem).IsInterface || typeof(TItem).IsAbstract)
{
return default;
}

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2040c95) to head (482fd11).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6619   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31672     31675    +3     
  Branches      4458      4459    +1     
=========================================
+ Hits         31672     31675    +3     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): support interface TItem

2 participants