Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 15, 2025

Link issues

fixes #6617

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the CustomerFilter sample to use localization, streamline the component markup, and integrate it into the TablesFilter demo for the Count column

Enhancements:

  • Inject IStringLocalizer into CustomerFilter to localize filter item texts
  • Initialize _items in OnInitialized using localized strings instead of hardcoded values
  • Simplify the CustomerFilter Razor markup to a single with default item and popover enabled Rename the bound Value field to _value and update Reset and GetFilterConditions methods accordingly Modify the TablesFilter demo to include CustomerFilter within a FilterTemplate for the Count column

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 15, 2025

Reviewer's Guide

This PR refactors the CustomerFilter component to support localization, standardizes its internal state naming and binding, streamlines the Razor markup, and updates the TablesFilter sample to demonstrate the new filter integration.

Sequence diagram for filter initialization with localization

sequenceDiagram
    participant CustomerFilter
    participant TableFilterLocalizer
    participant SelectedItem
    CustomerFilter->>TableFilterLocalizer: Request localized filter texts
    TableFilterLocalizer-->>CustomerFilter: Return localized strings
    CustomerFilter->>SelectedItem: Create filter items with localized text
    CustomerFilter->>CustomerFilter: Set _items with localized SelectedItems
Loading

Class diagram for updated CustomerFilter component

classDiagram
    class CustomerFilter {
        <<partial>>
        - IStringLocalizer<TablesFilter> TableFilterLocalizer
        - int? _value
        - List<SelectedItem> _items
        + void Reset()
        + FilterKeyValueAction GetFilterConditions()
        + void OnInitialized()
    }
    CustomerFilter --> TablesFilter : uses IStringLocalizer
    CustomerFilter --> SelectedItem : contains
Loading

File-Level Changes

Change Details Files
Add localization support to CustomerFilter component
  • Inject IStringLocalizer into the component
  • Replace hard-coded item texts with localized resource lookups
  • Populate the _items list in OnInitialized using localized strings
src/BootstrapBlazor.Server/Components/Components/CustomerFilter.razor.cs
Refactor internal value field and filter logic
  • Rename Value property to private field _value
  • Update Reset() and GetFilterConditions() to reference _value
  • Adjust binding logic in code-behind to use _value
src/BootstrapBlazor.Server/Components/Components/CustomerFilter.razor.cs
Streamline CustomerFilter Razor markup
  • Remove conditional header-row check and embed Select directly
  • Bind the Select component to _value instead of Value
  • Enable IsUseDefaultItemWhenValueIsNull and IsPopover on Select
src/BootstrapBlazor.Server/Components/Components/CustomerFilter.razor
Update TablesFilter sample to use the new filter
  • Replace DefaultSort settings on the Count column
  • Use FilterTemplate with FilterProvider to host CustomerFilter
  • Disable the ‘Show More’ button in the sample’s FilterProvider
src/BootstrapBlazor.Server/Components/Samples/Table/TablesFilter.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6617 Enable use of CustomFilter when ShowFilterHeader=true in Table component.
#6617 Update documentation and sample code to demonstrate how to use CustomFilter with ShowFilterHeader enabled.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the chore This are tasks or bot action label Aug 15, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 15, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Aug 15, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Components/CustomerFilter.razor:3` </location>
<code_context>
-{
-    <Select Items="@_items" @bind-Value="@Value"></Select>
-}
+<Select Items="@_items" @bind-Value="@_value" IsUseDefaultItemWhenValueIsNull="true" IsPopover="true"></Select>
</code_context>

<issue_to_address>
Check if IsUseDefaultItemWhenValueIsNull aligns with desired UX.

Please verify that showing the default item when _value is null is consistent with the intended filter behavior, particularly after a filter reset.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ffaf795) to head (7578fb4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6627   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31675     31675           
  Branches      4459      4459           
=========================================
  Hits         31675     31675           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 0b469ba into main Aug 15, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the doc-filter branch August 15, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(TableFilter): use OnFilterAsync instead of OnFilterValueChanged in CustomFilter

2 participants