Skip to content

feat(TableColumnFilter): revert support case-sensitive #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

feat(TableColumnFilter): revert support case-sensitive #6630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f13956
revert: 撤销 Contains 第二个参数
ArgoZhang Aug 15, 2025
a506ef3
test: 更新单元测试
ArgoZhang Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/BootstrapBlazor/Extensions/LambdaExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,8 @@ private static Expression GetExpression(this FilterKeyValueAction filter, Expres

private static BinaryExpression Contains(this Expression left, Expression right)
{
var method = typeof(string).GetMethod("Contains", [typeof(string), typeof(StringComparison)])!;
var comparison = Expression.Constant(StringComparison.OrdinalIgnoreCase);
return Expression.AndAlso(Expression.NotEqual(left, Expression.Constant(null)), Expression.Call(left, method, right, comparison));
var method = typeof(string).GetMethod("Contains", [typeof(string)])!;
return Expression.AndAlso(Expression.NotEqual(left, Expression.Constant(null)), Expression.Call(left, method, right));
}

#region Count
Expand Down
8 changes: 4 additions & 4 deletions test/UnitTest/Extensions/LambadaExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,10 @@ public void GetExpression_Contains()
var filter = new FilterKeyValueAction() { FieldKey = "Name", FieldValue = "test", FilterAction = FilterAction.Contains };
var invoker = filter.GetFilterLambda<Foo>().Compile();
Assert.True(invoker.Invoke(new Foo() { Name = "1test1" }));
Assert.True(invoker.Invoke(new Foo() { Name = "1Test1" }));
Assert.True(invoker.Invoke(new Foo() { Name = "1Test123" }));
Assert.True(invoker.Invoke(new Foo() { Name = "Test" }));
Assert.True(invoker.Invoke(new Foo() { Name = "Test2" }));
Assert.False(invoker.Invoke(new Foo() { Name = "1Test1" }));
Assert.False(invoker.Invoke(new Foo() { Name = "1Test123" }));
Assert.False(invoker.Invoke(new Foo() { Name = "Test" }));
Assert.False(invoker.Invoke(new Foo() { Name = "Test2" }));
}

[Fact]
Expand Down
Loading