Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Sep 4, 2025

Link issues

fixes #6714

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Switch the project to use the Longbow.TcpSocket package by updating service registration and sample code to the new API.

Bug Fixes:

Enhancements:

  • Replace BootstrapBlazor.TcpSocket with Longbow.TcpSocket across all sample components
  • Rename the ReceivedCallBack delegate to ReceivedCallback in sample code
  • Update the DI extension to use AddTcpSocketFactory instead of AddBootstrapBlazorTcpSocketFactory

Documentation:

  • Update package tips in Razor samples to reference Longbow.TcpSocket

Copilot AI review requested due to automatic review settings September 4, 2025 13:02
@bb-auto bb-auto bot added the enhancement New feature or request label Sep 4, 2025
@bb-auto bb-auto bot added this to the 9.10.0 milestone Sep 4, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR integrates the Longbow.TcpSocket package in place of the previous BootstrapBlazor.TcpSocket implementation by updating service registration, sample code event delegates, and package references.

Class diagram for updated TcpSocket client event delegate

classDiagram
    class ITcpSocketClient {
        +ReceivedCallback : delegate
        +IsConnected : bool
        +CloseAsync()
    }
    class DataPackageAdapter {
        +ReceivedCallback : delegate
    }
    ITcpSocketClient <|.. DataPackageAdapter
Loading

File-Level Changes

Change Details Files
Rename ReceivedCallBack delegate to ReceivedCallback
  • Update sample code to use ReceivedCallback property
  • Adjust event subscription and unsubscription operators (+=, -=)
src/BootstrapBlazor.Server/Components/Samples/Sockets/AutoReceives.razor
src/BootstrapBlazor.Server/Components/Samples/Sockets/AutoReceives.razor.cs
src/BootstrapBlazor.Server/Components/Samples/Sockets/Adapters.razor
src/BootstrapBlazor.Server/Components/Samples/Sockets/Adapters.razor.cs
src/BootstrapBlazor.Server/Components/Samples/Sockets/AutoReconnects.razor.cs
Update sample package references to Longbow.TcpSocket
  • Replace PackageTips entries with Longbow.TcpSocket
src/BootstrapBlazor.Server/Components/Samples/SocketFactories.razor
src/BootstrapBlazor.Server/Components/Samples/Sockets/Notice.razor
Update DI registration for TCP socket factory
  • Replace AddBootstrapBlazorTcpSocketFactory() with AddTcpSocketFactory()
src/BootstrapBlazor.Server/Extensions/ServiceCollectionSharedExtensions.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6714 Replace usage of BootstrapBlazor.TcpSocket package with Longbow.TcpSocket package in the codebase.
#6714 Update code references and service registrations to use Longbow.TcpSocket instead of BootstrapBlazor.TcpSocket.
#6714 Update documentation and UI elements (such as ) to reference Longbow.TcpSocket package.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 9ec0c0b into main Sep 4, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the refactor-socket branch September 4, 2025 13:03
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f3325b5) to head (4919dff).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6715   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31713     31713           
  Branches      4462      4462           
=========================================
  Hits         31713     31713           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from the BootstrapBlazor.TcpSocket package to the Longbow.TcpSocket package, updating package references and API usage throughout the codebase.

Key changes:

  • Replace BootstrapBlazor.TcpSocket and BootstrapBlazor.Socket packages with Longbow.TcpSocket and Longbow.Socket
  • Update API calls from ReceivedCallBack to ReceivedCallback (corrected spelling)
  • Update service registration method name from AddBootstrapBlazorTcpSocketFactory() to AddTcpSocketFactory()

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ServiceCollectionSharedExtensions.cs Updates service registration method call
Notice.razor Updates package name reference in UI component
AutoReconnects.razor.cs Updates callback property name from ReceivedCallBack to ReceivedCallback
AutoReceives.razor.cs Updates callback property name from ReceivedCallBack to ReceivedCallback
AutoReceives.razor Updates documentation and code examples with corrected callback property name
Adapters.razor.cs Updates callback property name from ReceivedCallBack to ReceivedCallback
Adapters.razor Updates code example with corrected callback property name
SocketFactories.razor Updates package name reference in UI component
BootstrapBlazor.Server.csproj Replaces old package references with new Longbow packages and updates using statements
BootstrapBlazor.slnx Adds localization files for ru-RU and uk-UA

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Socket): use Longbow.TcpSocket package

2 participants