-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Socket): use Longbow.TcpSocket package #6715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR integrates the Longbow.TcpSocket package in place of the previous BootstrapBlazor.TcpSocket implementation by updating service registration, sample code event delegates, and package references. Class diagram for updated TcpSocket client event delegateclassDiagram
class ITcpSocketClient {
+ReceivedCallback : delegate
+IsConnected : bool
+CloseAsync()
}
class DataPackageAdapter {
+ReceivedCallback : delegate
}
ITcpSocketClient <|.. DataPackageAdapter
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6715 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31713 31713
Branches 4462 4462
=========================================
Hits 31713 31713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates from the BootstrapBlazor.TcpSocket package to the Longbow.TcpSocket package, updating package references and API usage throughout the codebase.
Key changes:
- Replace BootstrapBlazor.TcpSocket and BootstrapBlazor.Socket packages with Longbow.TcpSocket and Longbow.Socket
- Update API calls from
ReceivedCallBacktoReceivedCallback(corrected spelling) - Update service registration method name from
AddBootstrapBlazorTcpSocketFactory()toAddTcpSocketFactory()
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ServiceCollectionSharedExtensions.cs | Updates service registration method call |
| Notice.razor | Updates package name reference in UI component |
| AutoReconnects.razor.cs | Updates callback property name from ReceivedCallBack to ReceivedCallback |
| AutoReceives.razor.cs | Updates callback property name from ReceivedCallBack to ReceivedCallback |
| AutoReceives.razor | Updates documentation and code examples with corrected callback property name |
| Adapters.razor.cs | Updates callback property name from ReceivedCallBack to ReceivedCallback |
| Adapters.razor | Updates code example with corrected callback property name |
| SocketFactories.razor | Updates package name reference in UI component |
| BootstrapBlazor.Server.csproj | Replaces old package references with new Longbow packages and updates using statements |
| BootstrapBlazor.slnx | Adds localization files for ru-RU and uk-UA |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Link issues
fixes #6714
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Switch the project to use the Longbow.TcpSocket package by updating service registration and sample code to the new API.
Bug Fixes:
Enhancements:
Documentation: